microblaze: commit 95521585 breakage

microblaze: commit 95521585 breakage

[John Williams]

Hi Sam, Michal,

Your MicroBlaze arch makefile cleanup commit
9552158573f847aa429334bb97995bb290bb4b0d had a rather unfortunate
error in it:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=950b260ed21fdb6fa5f18485dabb0b03488431fa

You intended to change CFLAGS_KERNEL to KBUILD_CFLAGS, but instead
changed CFLAGS_KERNEL to KBUILD_KERNEL.

The result?  No CPU feature optimisations across the entire MicroBlaze
kernel build :(

The fix is trivial - may I leave it to you to resolve and merge as
soon as possible?  This is a pretty serious performance regression.

Thanks,

John
-- 
John Williams, PhD, B.Eng, B.IT
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com  p: +61-7-30090663  f: +61-7-30090663

Re: microblaze: commit 95521585 breakage

[Sam Ravnborg]

On Thu, Sep 17, 2009 at 03:46:26PM +1000, John Williams wrote:
> Hi Sam, Michal,
> 
> Your MicroBlaze arch makefile cleanup commit
> 9552158573f847aa429334bb97995bb290bb4b0d had a rather unfortunate
> error in it:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=950b260ed21fdb6fa5f18485dabb0b03488431fa
> 
> You intended to change CFLAGS_KERNEL to KBUILD_CFLAGS, but instead
> changed CFLAGS_KERNEL to KBUILD_KERNEL.
> 
> The result?  No CPU feature optimisations across the entire MicroBlaze
> kernel build :(
> 
> The fix is trivial - may I leave it to you to resolve and merge as
> soon as possible?  This is a pretty serious performance regression.

Agree with the analysis of John.

Michael - I leave it to you to fix it up.

	Sam