mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Alan Cox <alan@linux.intel.com>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication
Date: Tue, 29 Sep 2009 13:02:51 +0200	[thread overview]
Message-ID: <200909291302.51432.borntraeger@de.ibm.com> (raw)
In-Reply-To: <20090929103354.GA3766@amit-x200.redhat.com>

Am Dienstag 29 September 2009 12:33:54 schrieben Sie:
> I've tested old qemu new kernel, new qemu old kernel, new qemu, new
> kernel and all the cases work fine.

The patch breaks at least s390 causing the following oops.

    <0>------------[ cut here ]------------                                                                       
    <2>Kernel BUG at 000000000087d902 [verbose debug info unavailable]                                            
    <4>illegal operation: 0001 [#1] SMP                                                                           
    <4>Modules linked in:                                                                                         
    <4>CPU: 0 Not tainted 2.6.31-selfgit-08936-g851b147-dirty #137                                                
    <4>Process swapper (pid: 1, task: 000000000c6de758, ksp: 000000000c6e3838)                                    
    <4>Krnl PSW : 0404200180000000 000000000087d902 (early_put_chars+0x6/0x98)                                    
    <4>           R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:0 CC:2 PM:0 EA:3                                         
    <4>Krnl GPRS: 0000000000000007 000000000087d8fc 0000000000000000 000000000c6e3c68                             
    <4>           0000000000000010 0000000000834408 0000000000000000 0000000000000000                             
    <4>           000000000c6e3c68 0000000000000000 0000000000000010 000000000000001a                             
    <4>           0000000000000010 0000000000558848 00000000003b6b32 000000000c6e3bc0                             
    <4>Krnl Code:>000000000087d902: cccccccccccc        unknown                                                   
    <4>           000000000087d908: cccccccccccc        unknown                                                   
    <4>           000000000087d90e: cccccccccccc        unknown                                                   
    <4>           000000000087d914: cccccccccccc        unknown                                                   
    <4>           000000000087d91a: cccccccccccc        unknown                                                   
    <4>Call Trace:                                                                                                
    <4>([<000000000c6e3cc8>] 0xc6e3cc8)                                                                           
    <4> [<000000000013f7cc>] __call_console_drivers+0xcc/0xe8                                                     
    <4> [<000000000013fdfa>] release_console_sem+0x1e2/0x29c                                                      
    <4> [<0000000000140606>] vprintk+0x316/0x498                                                                  
    <4> [<000000000051a846>] printk+0x52/0x64                                                                     
    <4> [<0000000000100240>] init_post+0x28/0x1a4                                                                 
    <4> [<000000000085a48e>] kernel_init+0x2d2/0x3b4                                                              
    <4> [<000000000010a212>] kernel_thread_starter+0x6/0xc                                                        
    <4> [<000000000010a20c>] kernel_thread_starter+0x0/0xc                                                        
    <4>Last Breaking-Event-Address:                                                                               
    <4> [<00000000003b6b30>] hvc_console_print+0x8c/0x12c                                                         
    <4>                                                                                                           
    <4>---[ end trace 1e5e8c448b0f2e2b ]--- 


I took a dump and had a look. It looks that this message thing is indeed not
the problem. Our early_put_chars method was marked as __init and the old code
replaced the put_chars method quickly enough to never make a problem.
Removing the __init from early_put_chars solved this kernel bug, but the tty
performance is now horribly slow. I will test, if the put_chars method is
replaced at all.

Christian



  reply	other threads:[~2009-09-29 11:02 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 14:13 Multiple ports support for virtio_console; major number for dev Amit Shah
2009-09-11 14:13 ` [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication Amit Shah
2009-09-11 16:00   ` Alan Cox
2009-09-11 16:38     ` Amit Shah
2009-09-11 17:26       ` Anthony Liguori
2009-09-11 17:33         ` Amit Shah
2009-09-11 17:35           ` Anthony Liguori
2009-09-16 10:23             ` Alan Cox
2009-09-16 22:20               ` Anthony Liguori
2009-09-17 13:06                 ` Markus Armbruster
2009-09-17 13:15                   ` Alan Cox
2009-09-17 13:41                     ` Amit Shah
2009-09-17 15:57                       ` Alan Cox
2009-09-17 16:46                         ` Amit Shah
2009-09-18 16:00                 ` Alan Cox
2009-09-18 17:55                   ` Anthony Liguori
2009-09-18 17:57                     ` H. Peter Anvin
2009-09-18 18:02                       ` Anthony Liguori
2009-09-19  7:04                       ` Amit Shah
2009-09-18 20:11                     ` Gerd Hoffmann
2009-09-19  7:01                     ` Amit Shah
2009-09-21 10:06                     ` Alan Cox
2009-09-15 12:37     ` Amit Shah
2009-09-15 12:57       ` Anthony Liguori
2009-09-15 13:03         ` Amit Shah
2009-09-15 13:37           ` Anthony Liguori
2009-09-15 14:08         ` Gerd Hoffmann
2009-09-15 14:09           ` Anthony Liguori
2009-09-22  2:44     ` Rusty Russell
2009-09-22 15:45       ` Amit Shah
2009-09-29  9:24         ` Amit Shah
2009-09-29 10:09           ` Christian Borntraeger
2009-09-29 10:33             ` Amit Shah
2009-09-29 11:02               ` Christian Borntraeger [this message]
2009-09-29 11:40                 ` Christian Borntraeger
2009-09-29 12:03           ` Christian Borntraeger
2009-09-29 12:20             ` Amit Shah
2009-09-29 12:56               ` Christian Borntraeger
2009-09-29 13:09                 ` Amit Shah
2009-09-29 13:31                   ` Christian Borntraeger
2009-09-30 17:13                     ` Amit Shah
2009-10-01  8:17                       ` Christian Borntraeger
2009-10-01  8:47                         ` Amit Shah
2009-10-01  8:55                           ` Christian Borntraeger
2009-10-01  9:00                       ` Christian Borntraeger
2009-10-01 10:04                         ` Amit Shah
2009-10-01 10:28                       ` Christian Borntraeger
2009-10-01 10:42                         ` Amit Shah
2009-10-01 11:58                         ` Amit Shah
2009-10-01 12:04                           ` Christian Borntraeger
2009-10-01 13:50                             ` Amit Shah
2009-10-05 14:05                         ` Amit Shah
2009-10-06  6:49                           ` Christian Borntraeger
2009-10-06  6:55                             ` Amit Shah
2009-09-29 13:11   ` Rusty Russell
2009-09-29 13:24     ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909291302.51432.borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=alan@linux.intel.com \
    --cc=amit.shah@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome