From: Borislav Petkov <petkovbb@googlemail.com>
To: Peter Feuerer <peter@piie.net>
Cc: Borislav Petkov <petkovbb@gmail.com>,
linux-kernel@vger.kernel.org, Andreas Mohr <andi@lisas.de>
Subject: Re: [Patch] acerhdf: Return temperature in milidegree
Date: Tue, 20 Oct 2009 09:27:53 +0200 [thread overview]
Message-ID: <20091020072752.GA9326@liondog.tnic> (raw)
In-Reply-To: <cone.1255986667.852662.3188.1000@deskpiie>
On Mon, Oct 19, 2009 at 11:11:07PM +0200, Peter Feuerer wrote:
> I just had a look at the documentation concerning this topic:
>
> Documentation/thermal/sysfs-api.txt:162
>
> temp Current temperature as reported by thermal zone (sensor)
> Unit: millidegree Celsius
> RO
> Required
>
>
> It is expected to be in millidegree, so I think we should discuss,
> modify and apply the patch.
Well well, looka here, it is an interface! I guess the temperature has
to be in millidegrees for better granularity or similar. Now userspace
has to do temp / 1000.0 and so on.
In that case, the patch should be applied. I'll give it a run later.
Minor nitpick: Add the sysfs-api requirement to the commit message
instead of "userspace applications."
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2009-10-20 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 8:21 Peter Feuerer
2009-10-19 9:16 ` Andreas Mohr
2009-10-19 21:24 ` Peter Feuerer
2009-10-20 5:25 ` Andreas Mohr
2009-10-19 18:51 ` Borislav Petkov
2009-10-19 21:11 ` Peter Feuerer
2009-10-20 7:27 ` Borislav Petkov [this message]
2009-11-02 11:02 ` Peter Feuerer
2009-11-02 12:49 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020072752.GA9326@liondog.tnic \
--to=petkovbb@googlemail.com \
--cc=andi@lisas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®