mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Feuerer <peter@piie.net>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: Borislav Petkov <petkovbb@gmail.com>,
	linux-kernel@vger.kernel.org, Andreas Mohr <andi@lisas.de>
Subject: Re: [Patch] acerhdf: Return temperature in milidegree
Date: Mon, 19 Oct 2009 23:11:07 +0200	[thread overview]
Message-ID: <cone.1255986667.852662.3188.1000@deskpiie> (raw)
In-Reply-To: <9ea470500910191151j370cec68w67ee8e31f42f3303@mail.gmail.com>

Hi Boris,

Borislav Petkov writes:

> Hi,
> 
> On Mon, Oct 19, 2009 at 10:21 AM, Peter Feuerer <peter@piie.net> wrote:
>> what do you think about this patch?
> 
> I don't think it is worth the trouble. Just compare the changes your
> patch introduces with a simple
> 
>  temp * 1000
> 
> you can do in userspace.
> 
> If this were a standard interface then maybe the changes could be
> warranted but it doesn't seem like so...
> 

I just had a look at the documentation concerning this topic: 

Documentation/thermal/sysfs-api.txt:162

temp           Current temperature as reported by thermal zone (sensor)
            Unit: millidegree Celsius
            RO
            Required


It is expected to be in millidegree, so I think we should discuss, modify 
and apply the patch.

regards,
--peter

  reply	other threads:[~2009-10-19 21:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19  8:21 Peter Feuerer
2009-10-19  9:16 ` Andreas Mohr
2009-10-19 21:24   ` Peter Feuerer
2009-10-20  5:25     ` Andreas Mohr
2009-10-19 18:51 ` Borislav Petkov
2009-10-19 21:11   ` Peter Feuerer [this message]
2009-10-20  7:27     ` Borislav Petkov
2009-11-02 11:02       ` Peter Feuerer
2009-11-02 12:49         ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cone.1255986667.852662.3188.1000@deskpiie \
    --to=peter@piie.net \
    --cc=andi@lisas.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®