Re: [Patch] acerhdf: Return temperature in milidegree

[Peter Feuerer <pfe@piie.net>]

Hi Boris,

Borislav Petkov writes:

> On Mon, Oct 19, 2009 at 11:11:07PM +0200, Peter Feuerer wrote:
>> I just had a look at the documentation concerning this topic:
>> 
>> Documentation/thermal/sysfs-api.txt:162
>> 
>> temp           Current temperature as reported by thermal zone (sensor)
>>            Unit: millidegree Celsius
>>            RO
>>            Required
>> 
>> 
>> It is expected to be in millidegree, so I think we should discuss,
>> modify and apply the patch.
> 
> Well well, looka here, it is an interface! I guess the temperature has
> to be in millidegrees for better granularity or similar. Now userspace
> has to do temp / 1000.0 and so on.

This is what the userspace applications like thermal-plugin of xfce-panel 
do.

> 
> In that case, the patch should be applied. I'll give it a run later.

Did you already give it a try?

> 
> Minor nitpick: Add the sysfs-api requirement to the commit message
> instead of "userspace applications."

will change this, when submitting the patch to Andrew.

kind regards,
--peter