mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* some recent scheduler patches
@ 2009-12-02 18:53 Nick Piggin
  2009-12-02 19:04 ` Peter Zijlstra
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Piggin @ 2009-12-02 18:53 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Linux Kernel Mailing List, Mike Galbraith

Hi,

I'm just been looking through some of the recent scheduler patches
while bisecting something...

83f54960c11a14942ab00b54c51e91906b9d8235: sched: for_each_domain() vs RCU
I don't see what is the step that causes FAIL? sched-domains code is
using synchronize_sched(), so that part should be safe.

And b8a543ea5a5896830a9969bacfd047f9d15940b2... This changelog is not
correct to start with. The _idx stuff does not just shift the time
that balancing decisions are made, it damps balancing choices to be
more conservative if they might have been wrong over more than a single
instant sample.

And secondly there is no reason give for the change. Ditto for a lot of
other tuning changes really. Not that there was always exact reasons
for every single one of the defaults I found, but they a) always tried
to get reasonable performance with as conservative balancing as
possible (ie. so 2 different tunings with no distinguishable difference
then tuning that result in fewer task movements would be preferred).
And b) they were relatively well tested.

Are people really not reporting enough regressions against CFS that it
is time to just tweak things?


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: some recent scheduler patches
  2009-12-02 18:53 some recent scheduler patches Nick Piggin
@ 2009-12-02 19:04 ` Peter Zijlstra
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2009-12-02 19:04 UTC (permalink / raw)
  To: Nick Piggin; +Cc: Ingo Molnar, Linux Kernel Mailing List, Mike Galbraith

On Wed, 2009-12-02 at 19:53 +0100, Nick Piggin wrote:
> 
> 
> 83f54960c11a14942ab00b54c51e91906b9d8235: sched: for_each_domain() vs RCU
> I don't see what is the step that causes FAIL? sched-domains code is
> using synchronize_sched(), so that part should be safe.

Yeah, I got myself properly confused there. I was meaning to remove that
rcu_read_lock() there again.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-02 19:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-02 18:53 some recent scheduler patches Nick Piggin
2009-12-02 19:04 ` Peter Zijlstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®