mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	Tom Zanussi <tzanussi@gmail.com>,
	Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH 2/2] perf lock: New subcommand "lock" to perf for analyzing lock statistics
Date: Mon, 7 Dec 2009 08:27:52 +0100	[thread overview]
Message-ID: <20091207072752.GG10868@elte.hu> (raw)
In-Reply-To: <20091207044125.GB5262@nowhere>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> On Mon, Dec 07, 2009 at 12:34:44PM +0900, Hitoshi Mitake wrote:
> > This patch adds new subcommand "lock" to perf for analyzing lock usage statistics.
> > Current perf lock is very primitive. This cannot provide the minimum functions.
> > Of course I continue to working on this.
> > But too big patch is not good thing for you, so I post this.
> 
> Oh great!
> Yeah, the work can be done incrementally.
>
[...]
>
> 
> Very nice and promising!
> 
> I can't wait to try it.

ok, to ease testing i've created a new (and not yet permanent) topic 
tree for it to track this new perf feature: tip:perf/lock and pushed it 
out.

Note: because it's not yet in a final form i have not merged it into 
tip:master yet - when you are working on these bits you need to do this 
manually via:

  git merge tip/perf/lock

Also, we might need to rebase this branch as it's WIP, so the commit IDs 
are not permanent yet. But i thought it would be easier to do deltas on 
this basis.

Hitoshi-san, the patches did not have a Signed-off-by line from you, can 
i add them for you?

Also, i agree that the performance aspect is probably the most pressing 
issue. Note that 'perf bench sched messaging' is very locking intense so 
a 10x slowdown is not entirely unexpected - we still ought to optimize 
it all some more. 'perf lock' is an excellent testcase for this in any 
case.

Thanks,

	Ingo

  reply	other threads:[~2009-12-07  7:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12  6:43 [PATCH][RFC] Measuring term of acquiring spinlock Hitoshi Mitake
2009-11-12  7:39 ` Ingo Molnar
2009-11-13  4:21   ` Hitoshi Mitake
2009-11-13  8:17     ` Ingo Molnar
2009-11-13  8:24       ` Peter Zijlstra
2009-11-13  8:40       ` Frederic Weisbecker
2009-11-13  8:51         ` Ingo Molnar
2009-11-13  9:06           ` [PATCH] tracing: Rename lockdep event subsystem into lock Frederic Weisbecker
2009-11-13  9:10             ` Peter Zijlstra
2009-11-13  9:26               ` Ingo Molnar
2009-11-13  9:36               ` Frederic Weisbecker
2009-11-13  9:31             ` [tip:perf/core] tracing: Rename 'lockdep' event subsystem into 'lock' tip-bot for Frederic Weisbecker
2009-11-13  9:57             ` tip-bot for Frederic Weisbecker
2009-11-13 10:51     ` [PATCH][RFC] Measuring term of acquiring spinlock Frederic Weisbecker
2009-11-15  1:20       ` Hitoshi Mitake
2009-11-15  2:21         ` Frederic Weisbecker
2009-11-15  8:38           ` Hitoshi Mitake
2009-12-07  3:34           ` [PATCH 1/2] Does raw_field_ptr() supports __data_loc? Hitoshi Mitake
2009-12-07  4:02             ` Frederic Weisbecker
2009-12-07 16:09             ` Steven Rostedt
2009-12-07  3:34           ` [PATCH 2/2] perf lock: New subcommand "lock" to perf for analyzing lock statistics Hitoshi Mitake
2009-12-07  4:41             ` Frederic Weisbecker
2009-12-07  7:27               ` Ingo Molnar [this message]
2009-12-07  8:38                 ` Xiao Guangrong
2009-12-07 15:00                   ` Hitoshi Mitake
2009-12-07 16:38                   ` Steven Rostedt
2009-12-07 19:48                   ` Frederic Weisbecker
2009-12-07 19:57                     ` Frederic Weisbecker
2009-12-08  1:31                     ` Xiao Guangrong
2009-12-07 14:57                 ` Hitoshi Mitake
2009-12-07 14:51               ` Hitoshi Mitake
2009-12-07 20:16                 ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207072752.GG10868@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=paulus@samba.org \
    --cc=srostedt@redhat.com \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®