* [PATCH 5/12] drivers/media/video/uvc: Correct size given to memset
@ 2009-12-09 19:23 Julia Lawall
2009-12-10 2:05 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-12-09 19:23 UTC (permalink / raw)
To: Laurent Pinchart, Mauro Carvalho Chehab, linux-media,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Memset should be given the size of the structure, not the size of the pointer.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T *x;
expression E;
@@
memset(x, E, sizeof(
+ *
x))
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/media/video/uvc/uvc_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c
--- a/drivers/media/video/uvc/uvc_video.c
+++ b/drivers/media/video/uvc/uvc_video.c
@@ -145,7 +145,7 @@ static int uvc_get_video_ctrl(struct uvc
uvc_warn_once(stream->dev, UVC_WARN_MINMAX, "UVC non "
"compliance - GET_MIN/MAX(PROBE) incorrectly "
"supported. Enabling workaround.\n");
- memset(ctrl, 0, sizeof ctrl);
+ memset(ctrl, 0, sizeof *ctrl);
ctrl->wCompQuality = le16_to_cpup((__le16 *)data);
ret = 0;
goto out;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 5/12] drivers/media/video/uvc: Correct size given to memset
2009-12-09 19:23 [PATCH 5/12] drivers/media/video/uvc: Correct size given to memset Julia Lawall
@ 2009-12-10 2:05 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2009-12-10 2:05 UTC (permalink / raw)
To: Julia Lawall
Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, kernel-janitors
Hi Julia,
thanks for the patch.
On Wednesday 09 December 2009 20:23:49 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Memset should be given the size of the structure, not the size of the
> pointer.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> type T;
> T *x;
> expression E;
> @@
>
> memset(x, E, sizeof(
> + *
> x))
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-10 2:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-09 19:23 [PATCH 5/12] drivers/media/video/uvc: Correct size given to memset Julia Lawall
2009-12-10 2:05 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®