* [PATCH] vfs: don't call ima_file_check() unconditionally in nfsd_open()
@ 2010-02-15 23:07 Chuck Ebbert
2010-02-16 14:33 ` Mimi Zohar
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Ebbert @ 2010-02-15 23:07 UTC (permalink / raw)
To: Al Viro; +Cc: linux-kernel, Mimi Zohar
From: Chuck Ebbert <cebbert@redhat.com>
vfs: don't call ima_file_check() unconditionally in nfsd_open()
commit 1e41568d7378d1ba8c64ba137b9ddd00b59f893a ("Take ima_path_check()
in nfsd past dentry_open() in nfsd_open()") moved this code back to its
original location but missed the "else".
Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
--- linux-2.6.32.noarch.orig/fs/nfsd/vfs.c
+++ linux-2.6.32.noarch/fs/nfsd/vfs.c
@@ -752,7 +752,8 @@ nfsd_open(struct svc_rqst *rqstp, struct
flags, current_cred());
if (IS_ERR(*filp))
host_err = PTR_ERR(*filp);
- host_err = ima_file_check(*filp, access);
+ else
+ host_err = ima_file_check(*filp, access);
out_nfserr:
err = nfserrno(host_err);
out:
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] vfs: don't call ima_file_check() unconditionally in nfsd_open()
2010-02-15 23:07 [PATCH] vfs: don't call ima_file_check() unconditionally in nfsd_open() Chuck Ebbert
@ 2010-02-16 14:33 ` Mimi Zohar
0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2010-02-16 14:33 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Al Viro, James Morris, linux-kernel, Mimi Zohar
On Mon, 2010-02-15 at 18:07 -0500, Chuck Ebbert wrote:
> From: Chuck Ebbert <cebbert@redhat.com>
>
> vfs: don't call ima_file_check() unconditionally in nfsd_open()
>
> commit 1e41568d7378d1ba8c64ba137b9ddd00b59f893a ("Take ima_path_check()
> in nfsd past dentry_open() in nfsd_open()") moved this code back to its
> original location but missed the "else".
>
> Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
Thanks for catching it.
Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> --- linux-2.6.32.noarch.orig/fs/nfsd/vfs.c
> +++ linux-2.6.32.noarch/fs/nfsd/vfs.c
> @@ -752,7 +752,8 @@ nfsd_open(struct svc_rqst *rqstp, struct
> flags, current_cred());
> if (IS_ERR(*filp))
> host_err = PTR_ERR(*filp);
> - host_err = ima_file_check(*filp, access);
> + else
> + host_err = ima_file_check(*filp, access);
> out_nfserr:
> err = nfserrno(host_err);
> out:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-16 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-15 23:07 [PATCH] vfs: don't call ima_file_check() unconditionally in nfsd_open() Chuck Ebbert
2010-02-16 14:33 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®