From: Roland McGrath <roland@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
suresh.b.siddha@intel.com, tglx@linutronix.de,
hjl.tools@gmail.com, linux-tip-commits@vger.kernel.org,
Kyle McMartin <kyle@mcmartin.ca>
Subject: Re: [tip:x86/ptrace] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET
Date: Mon, 22 Feb 2010 10:37:07 -0800 (PST) [thread overview]
Message-ID: <20100222183707.8749D64C@magilla.sf.frob.com> (raw)
In-Reply-To: Ingo Molnar's message of Monday, 22 February 2010 10:07:10 +0100 <20100222090710.GA31357@elte.hu>
> FYI, this commit broke tip:master on PARISC (other architectures are fine):
>
> kernel/built-in.o: In function `ptrace_request':
> (.text.ptrace_request+0x2cc): undefined reference to `task_user_regset_view'
This means that parisc failed to meet the documented requirements for
setting CONFIG_HAVE_ARCH_TRACEHOOK, but set it anyway. If arch folks don't
follow the specs, it defeats the whole purpose of having clear statements
of requirements for arch code.
> I'll keep them in tip:master to get them tested, but note that i cannot push
> any of these patches into linux-next until this is fixed, as linux-next
> requires all architectures to build, with no regard to which architectures are
> tested by kernel testers in practice.
IMHO if parisc does not finish up its requirements RSN, it should instead:
diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
index 524d935..f388dc6 100644
--- a/arch/parisc/Kconfig
+++ b/arch/parisc/Kconfig
@@ -18,7 +18,6 @@ config PARISC
select BUG
select HAVE_PERF_EVENTS
select GENERIC_ATOMIC64 if !64BIT
- select HAVE_ARCH_TRACEHOOK
help
The PA-RISC microprocessor is designed by Hewlett-Packard and used
in many of their workstations & servers (HP9000 700 and 800 series,
Thanks,
Roland
next prev parent reply other threads:[~2010-02-22 18:37 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 19:50 [patch v3 0/2] updated ptrace/core-dump patches for supporting xstate - v3 Suresh Siddha
2010-02-11 19:50 ` [patch v3 1/2] x86, ptrace: regset extensions to support xstate Suresh Siddha
2010-02-11 23:18 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-12 3:45 ` [patch v3 1/2] " Roland McGrath
2010-02-12 17:31 ` Oleg Nesterov
2010-02-11 19:51 ` [patch v3 2/2] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET Suresh Siddha
2010-02-11 23:19 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
2010-02-22 9:07 ` Ingo Molnar
2010-02-22 9:33 ` linux-next requiements (Was: Re: [tip:x86/ptrace] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET) Stephen Rothwell
2010-02-22 10:27 ` Ingo Molnar
2010-02-22 11:47 ` linux-next requirements " Stephen Rothwell
2010-02-22 22:57 ` H. Peter Anvin
2010-02-22 23:59 ` Stephen Rothwell
2010-02-23 20:20 ` Roland McGrath
2010-02-23 20:49 ` H. Peter Anvin
2010-02-23 22:54 ` Stephen Rothwell
2010-02-23 8:45 ` Ingo Molnar
2010-02-23 19:52 ` Al Viro
2010-02-23 19:57 ` Al Viro
2010-02-24 7:25 ` linux-next requirements Stephen Rothwell
2010-02-27 1:53 ` Grant Likely
2010-02-27 8:53 ` Geert Uytterhoeven
2010-02-27 9:09 ` Jaswinder Singh Rajput
2010-02-27 9:39 ` Ingo Molnar
2010-02-27 12:23 ` Rafael J. Wysocki
2010-02-27 12:47 ` Ingo Molnar
2010-02-27 19:07 ` Rafael J. Wysocki
2010-02-27 21:50 ` Geert Uytterhoeven
2010-02-27 22:31 ` Rafael J. Wysocki
2010-02-28 7:06 ` Ingo Molnar
2010-02-28 12:22 ` Rafael J. Wysocki
2010-02-28 7:14 ` Ingo Molnar
2010-02-28 7:37 ` Stephen Rothwell
2010-02-28 7:51 ` Ingo Molnar
2010-02-28 8:19 ` Al Viro
2010-02-28 8:53 ` Ingo Molnar
2010-02-28 10:26 ` Stephen Rothwell
2010-02-28 7:23 ` Ingo Molnar
2010-03-01 15:13 ` Nick Bowler
2010-03-03 21:53 ` Pavel Machek
2010-03-04 0:35 ` Thomas Gleixner
2010-03-04 0:42 ` Andrew Morton
2010-03-04 1:17 ` Thomas Gleixner
2010-03-04 2:48 ` Ingo Molnar
2010-02-22 18:37 ` Roland McGrath [this message]
2010-02-23 18:36 ` [tip:x86/ptrace] parisc: Disable CONFIG_HAVE_ARCH_TRACEHOOK tip-bot for Roland McGrath
2010-02-12 3:56 ` [patch v3 2/2] ptrace: Add support for generic PTRACE_GETREGSET/PTRACE_SETREGSET Roland McGrath
2010-02-12 15:59 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2010-02-09 20:13 [patch v2 4/4] " Suresh Siddha
2010-02-09 22:55 ` [tip:x86/ptrace] " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222183707.8749D64C@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome