From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Kalhan Trisal <kalhan.trisal@intel.com>,
Jonathan Cameron <kernel@jic23.retrosnub.co.uk>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass
Date: Thu, 15 Apr 2010 13:11:53 +0100 [thread overview]
Message-ID: <20100415131153.0e383ef3@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1271280993.1833.36.camel@Joe-Laptop.home>
> Argument alignment
Makes it take more space
> Spacing
Mostly dropped
> Make chars static
Not sure I see the point (compiler generates good code anyway)
> Remove prefixes from dev_<level> logging
Good point.
next prev parent reply other threads:[~2010-04-15 12:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 12:51 [PATCH 0/4] Various intel small device drivers Alan Cox
2010-04-14 12:51 ` [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass Alan Cox
2010-04-14 13:48 ` Jonathan Cameron
2010-04-14 14:32 ` Alan Cox
2010-04-14 14:51 ` Jonathan Cameron
2010-04-14 15:19 ` Alan Cox
2010-04-14 16:39 ` Jonathan Cameron
2010-04-14 21:36 ` Joe Perches
2010-04-15 12:11 ` Alan Cox [this message]
2010-04-15 15:57 ` Joe Perches
2010-04-14 16:56 ` isl29020: ALS driver as misc device Alan Cox
2010-04-14 17:01 ` Greg KH
2010-04-15 10:09 ` Jonathan Cameron
2010-04-15 11:17 ` Alan Cox
2010-04-26 10:59 ` Jonathan Cameron
2010-04-14 12:51 ` [PATCH 2/4] isl29020: ambient light sensor Alan Cox
2010-04-14 22:45 ` Daniel Mack
2010-04-14 22:35 ` Alan Cox
2010-04-15 6:20 ` Daniel Mack
2010-04-15 10:15 ` Jonathan Cameron
2010-04-14 12:52 ` [PATCH 3/4] liss331d1: accelerometer driver Alan Cox
2010-04-14 22:12 ` Éric Piel
2010-04-14 22:34 ` Daniel Mack
2010-04-14 23:05 ` Neil Brown
2010-04-15 9:47 ` Éric Piel
2010-04-14 22:37 ` Alan Cox
2010-04-15 10:28 ` Jonathan Cameron
2010-04-15 10:02 ` Alan Cox
2010-04-15 19:12 ` Pavel Machek
2010-04-14 12:52 ` [PATCH 4/4] emc1403: thermal sensor support Alan Cox
2010-04-14 13:30 ` [PATCH 0/4] Various intel small device drivers Jean Delvare
2010-04-14 13:49 ` Alan Cox
2010-04-14 13:55 ` Jonathan Cameron
2010-04-14 14:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415131153.0e383ef3@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=joe@perches.com \
--cc=kalhan.trisal@intel.com \
--cc=kernel@jic23.retrosnub.co.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®