From: Jonathan Cameron <kernel@jic23.retrosnub.co.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Alan Cox <alan@linux.intel.com>,
linux-i2c@vger.kernel.org, khali@linux-fr.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass
Date: Wed, 14 Apr 2010 15:51:45 +0100 [thread overview]
Message-ID: <4BC5D681.20707@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <20100414153234.22765666@lxorguk.ukuu.org.uk>
On 04/14/10 15:32, Alan Cox wrote:
>> This is in no way a hwmon chip. Surely misc is a better location for now
>> (pending the usual discussion about all singing all dancing sensors frameworks).
>
> Yep it's moving at the moment
>
>
>>> +#include <linux/module.h>
>>> +#include <linux/init.h>
>>> +#include <linux/slab.h>
>>> +#include <linux/i2c.h>
>>> +#include <linux/hwmon.h>
>>
>> Why these extra hwmon includes? At least at first glance I can't see
>> any uses of them. The only call to hwmon is to stick this in the
>> hwmon class.
>
> I inherited it for cleanup so these are good points (I've been staring at
> piles of these for so long extra input is very useful - this is the tip
> of the iceberg !)
Cool, post away. Feel free to cc me in on anything in the category of general
sensors (accelerometers, magnetometers etc). If nothing else, I'm interested
to see them to get ideas for drivers in IIO etc.
>
>>> +#include <linux/hwmon-sysfs.h>
>>> +#include <linux/hwmon-vid.h>
>>> +#include <linux/err.h>
>>> +#include <linux/delay.h>
>> or any mutex usage?
>>> +#include <linux/mutex.h>
>>> +#include <linux/sysfs.h>
>>> +
>>
>> I guess this makes the driver look like many others, but why bother with
>> the wrapping structure? This is only used to keep track of the hwmon
>> device to be able to remove it later.
>
> Should go - agreed will remove
>
>> These address changes looking a little unusual to me. They may well be needed, but
>> if so can we have an explanatory comment?
>
> Will investigate.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2010-04-14 14:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 12:51 [PATCH 0/4] Various intel small device drivers Alan Cox
2010-04-14 12:51 ` [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass Alan Cox
2010-04-14 13:48 ` Jonathan Cameron
2010-04-14 14:32 ` Alan Cox
2010-04-14 14:51 ` Jonathan Cameron [this message]
2010-04-14 15:19 ` Alan Cox
2010-04-14 16:39 ` Jonathan Cameron
2010-04-14 21:36 ` Joe Perches
2010-04-15 12:11 ` Alan Cox
2010-04-15 15:57 ` Joe Perches
2010-04-14 16:56 ` isl29020: ALS driver as misc device Alan Cox
2010-04-14 17:01 ` Greg KH
2010-04-15 10:09 ` Jonathan Cameron
2010-04-15 11:17 ` Alan Cox
2010-04-26 10:59 ` Jonathan Cameron
2010-04-14 12:51 ` [PATCH 2/4] isl29020: ambient light sensor Alan Cox
2010-04-14 22:45 ` Daniel Mack
2010-04-14 22:35 ` Alan Cox
2010-04-15 6:20 ` Daniel Mack
2010-04-15 10:15 ` Jonathan Cameron
2010-04-14 12:52 ` [PATCH 3/4] liss331d1: accelerometer driver Alan Cox
2010-04-14 22:12 ` Éric Piel
2010-04-14 22:34 ` Daniel Mack
2010-04-14 23:05 ` Neil Brown
2010-04-15 9:47 ` Éric Piel
2010-04-14 22:37 ` Alan Cox
2010-04-15 10:28 ` Jonathan Cameron
2010-04-15 10:02 ` Alan Cox
2010-04-15 19:12 ` Pavel Machek
2010-04-14 12:52 ` [PATCH 4/4] emc1403: thermal sensor support Alan Cox
2010-04-14 13:30 ` [PATCH 0/4] Various intel small device drivers Jean Delvare
2010-04-14 13:49 ` Alan Cox
2010-04-14 13:55 ` Jonathan Cameron
2010-04-14 14:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC5D681.20707@jic23.retrosnub.co.uk \
--to=kernel@jic23.retrosnub.co.uk \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®