From: Jonathan Cameron <kernel@jic23.retrosnub.co.uk>
To: Greg KH <greg@kroah.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Alan Cox <alan@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: isl29020: ALS driver as misc device
Date: Thu, 15 Apr 2010 11:09:19 +0100 [thread overview]
Message-ID: <4BC6E5CF.9070302@jic23.retrosnub.co.uk> (raw)
In-Reply-To: <20100414170153.GA7494@kroah.com>
On 04/14/10 18:01, Greg KH wrote:
> On Wed, Apr 14, 2010 at 05:56:02PM +0100, Alan Cox wrote:
>> And this adds the isl29020 as a misc device per discussions
>>
>> isl29020: ambient light sensor
>>
>> From: Kalhan Trisal <kalhan.trisal@intel.com>
>>
>> The LS driver will read the latest Lux measurement based upon the
>> light brightness and will report the LUX output through sysfs interface.
>
> Please document this sysfs interface with an addition to the
> Documentatin/ABI/ directory.
As documenting this abi (which indeed should be done) is going to set
a precedence, perhaps this is a good time to discuss what this naming could
be.
In cleaning up the IIO abi Greg suggested that we match existing similar
abi's a closely as possible, which where possible makes a great deal of sense
(shared userspace code is possible and it makes everything a bit more predictable
for driver writers... particularly as I expect someone will sooner or later
make a combined hwmon and als chip).
The obvious similarity here is with hwmon.
So perhaps going with naming as
lux-> illuminance0_input (or I guess lux0_input would also work, I can change
the iio abi to match this as well).
It also occurs to me that we might want to associate the calibration with the
particular channel? There's sure to be a dual ALS chip along at some point.
Obviously the isl29020 would need updating as well. Everyone was happy to do
that when were writing the ALS subsystem, so I guess that won't have changed!
Jonathan
next prev parent reply other threads:[~2010-04-15 10:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 12:51 [PATCH 0/4] Various intel small device drivers Alan Cox
2010-04-14 12:51 ` [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass Alan Cox
2010-04-14 13:48 ` Jonathan Cameron
2010-04-14 14:32 ` Alan Cox
2010-04-14 14:51 ` Jonathan Cameron
2010-04-14 15:19 ` Alan Cox
2010-04-14 16:39 ` Jonathan Cameron
2010-04-14 21:36 ` Joe Perches
2010-04-15 12:11 ` Alan Cox
2010-04-15 15:57 ` Joe Perches
2010-04-14 16:56 ` isl29020: ALS driver as misc device Alan Cox
2010-04-14 17:01 ` Greg KH
2010-04-15 10:09 ` Jonathan Cameron [this message]
2010-04-15 11:17 ` Alan Cox
2010-04-26 10:59 ` Jonathan Cameron
2010-04-14 12:51 ` [PATCH 2/4] isl29020: ambient light sensor Alan Cox
2010-04-14 22:45 ` Daniel Mack
2010-04-14 22:35 ` Alan Cox
2010-04-15 6:20 ` Daniel Mack
2010-04-15 10:15 ` Jonathan Cameron
2010-04-14 12:52 ` [PATCH 3/4] liss331d1: accelerometer driver Alan Cox
2010-04-14 22:12 ` Éric Piel
2010-04-14 22:34 ` Daniel Mack
2010-04-14 23:05 ` Neil Brown
2010-04-15 9:47 ` Éric Piel
2010-04-14 22:37 ` Alan Cox
2010-04-15 10:28 ` Jonathan Cameron
2010-04-15 10:02 ` Alan Cox
2010-04-15 19:12 ` Pavel Machek
2010-04-14 12:52 ` [PATCH 4/4] emc1403: thermal sensor support Alan Cox
2010-04-14 13:30 ` [PATCH 0/4] Various intel small device drivers Jean Delvare
2010-04-14 13:49 ` Alan Cox
2010-04-14 13:55 ` Jonathan Cameron
2010-04-14 14:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC6E5CF.9070302@jic23.retrosnub.co.uk \
--to=kernel@jic23.retrosnub.co.uk \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®