[RFC PATCH 4/4] Mobile security processor driver

[RFC PATCH 4/4] Mobile security processor driver

[Epshteyn, Eugene]

[-- Attachment #1: Type: text/plain, Size: 1752 bytes --]

>From 9230c90ce19747554354c9fc93b3b1c8e661894c Mon Sep 17 00:00:00 2001
From: Mark Allyn <mark.a.allyn@intel.com>
Date: Wed, 28 Apr 2010 14:41:39 -0700
Subject: RFC [PATCH 4/4] staging: sep: Update TODO

Signed-off-by: Mark A. Allyn <mark.a.allyn@intel.com>
---
  drivers/staging/sep/TODO |   36 ++++++++++++++++++++++++++++--------
  1 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/sep/TODO b/drivers/staging/sep/TODO
index ff0e931..1a8f876 100644
--- a/drivers/staging/sep/TODO
+++ b/drivers/staging/sep/TODO
@@ -1,8 +1,28 @@
-Todo's so far (from Alan Cox)
-- Fix firmware loading
-- Get firmware into firmware git tree
-- Review and tidy each algorithm function
-- Check whether it can be plugged into any of the kernel crypto API
-  interfaces
-- Do something about the magic shared memory interface and replace it
-  with something saner (in Linux terms)
+Todo's so far (from Mark Allyn)
+
+- Resolve issue wiht allowing user space software to handle
+  physical addresses
+
+- Determine device types at runtime
+
+- Ensure that all global variables be either static or be in a global structure;
+  preferably in structure
+
+- Fix formatting (it did pass checkpatch, but it's still awkward
+
+- Fix problems in singleton opens
+
+- Provide documentation on mutex, test and set, and other locking
+
+- Fix process exit logic in caller ID handler
+
+- Need to unmap memory in case of failure
+
+- Need to document errors
+
+- Fix the way the device is set up; let the probe do the stuff such as
+  registering the device with the driver
+
+- Use cpu_to_le or cpu_to_bt instead of SEP_CHANGE_ENDIANNES
+
+- Don't use 32 bit values for virtual addresses
--
1.6.0.4

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0004-staging-sep-Update-TODO.patch --]
[-- Type: text/x-diff; name="0004-staging-sep-Update-TODO.patch", Size: 1752 bytes --]

From 9230c90ce19747554354c9fc93b3b1c8e661894c Mon Sep 17 00:00:00 2001
From: Mark Allyn <mark.a.allyn@intel.com>
Date: Wed, 28 Apr 2010 14:41:39 -0700
Subject: RFC [PATCH 4/4] staging: sep: Update TODO

Signed-off-by: Mark A. Allyn <mark.a.allyn@intel.com>
---
 drivers/staging/sep/TODO |   36 ++++++++++++++++++++++++++++--------
 1 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/sep/TODO b/drivers/staging/sep/TODO
index ff0e931..1a8f876 100644
--- a/drivers/staging/sep/TODO
+++ b/drivers/staging/sep/TODO
@@ -1,8 +1,28 @@
-Todo's so far (from Alan Cox)
-- Fix firmware loading
-- Get firmware into firmware git tree
-- Review and tidy each algorithm function
-- Check whether it can be plugged into any of the kernel crypto API
-  interfaces
-- Do something about the magic shared memory interface and replace it
-  with something saner (in Linux terms)
+Todo's so far (from Mark Allyn)
+
+- Resolve issue wiht allowing user space software to handle
+  physical addresses
+
+- Determine device types at runtime
+
+- Ensure that all global variables be either static or be in a global structure;
+  preferably in structure
+
+- Fix formatting (it did pass checkpatch, but it's still awkward
+
+- Fix problems in singleton opens
+
+- Provide documentation on mutex, test and set, and other locking
+
+- Fix process exit logic in caller ID handler
+
+- Need to unmap memory in case of failure
+
+- Need to document errors
+
+- Fix the way the device is set up; let the probe do the stuff such as
+  registering the device with the driver
+
+- Use cpu_to_le or cpu_to_bt instead of SEP_CHANGE_ENDIANNES
+
+- Don't use 32 bit values for virtual addresses
-- 
1.6.0.4

Re: [RFC PATCH 4/4] Mobile security processor driver

[Greg KH]

On Wed, Apr 28, 2010 at 04:10:52PM -0700, Epshteyn, Eugene wrote:
> >From 9230c90ce19747554354c9fc93b3b1c8e661894c Mon Sep 17 00:00:00 2001
> From: Mark Allyn <mark.a.allyn@intel.com>
> Date: Wed, 28 Apr 2010 14:41:39 -0700
> Subject: RFC [PATCH 4/4] staging: sep: Update TODO

Why are you including the patch twice?

> --- a/drivers/staging/sep/TODO
> +++ b/drivers/staging/sep/TODO

<snip>

Here's your list of what needs to be done to get this code merged, why
have you ignored it when asking us what we thought needed to be done.
Isn't this a good enough list of things left to complete?

again, totally confused,

greg k-h

Re: [RFC PATCH 4/4] Mobile security processor driver

[Alan Cox]

> -Todo's so far (from Alan Cox)
> -- Fix firmware loading
> -- Get firmware into firmware git tree
> -- Review and tidy each algorithm function
> -- Check whether it can be plugged into any of the kernel crypto API
> -  interfaces
> -- Do something about the magic shared memory interface and replace it
> -  with something saner (in Linux terms)

But those you are deleting are not fixed ?