From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Arjan van de Ven <arjan@linux.jf.intel.com>
Cc: Venkatesh Pallipadi <venki@google.com>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
ego@in.ibm.com, LKML <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Nigel Cunningham <ncunningham@crca.org.au>,
Suresh Siddha <suresh.b.siddha@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <jens.axboe@oracle.com>
Subject: [patch 3/7] softirq: avoid softirq_work_list for SCHED_SOFTIRQ when sent remotely
Date: Mon, 17 May 2010 11:27:29 -0700 [thread overview]
Message-ID: <20100517184027.777058425@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <20100517182726.089700767@sbs-t61.sc.intel.com>
[-- Attachment #1: fix_local_trigger_remote_softirq_for_sched.patch --]
[-- Type: text/plain, Size: 1141 bytes --]
There is no need to add the SCHED_SOFTIRQ work to the softirq_work_list
when sent remotely. This is because any pending work associated with
SCHED_SOFTIRQ need not be migrated to a new cpu when the current cpu is
going down etc.
Also I am not sure how this softirq_work_list works for other softirqs.
I don't see anyone removing the list entries from the softirq_work_list
after it is handled on a remote cpu.
For now, just skip it for SCHED_SOFTIRQ.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jens Axboe <jens.axboe@oracle.com>
---
kernel/softirq.c | 5 +++++
1 file changed, 5 insertions(+)
Index: tip/kernel/softirq.c
===================================================================
--- tip.orig/kernel/softirq.c
+++ tip/kernel/softirq.c
@@ -557,6 +557,11 @@ static void __local_trigger(struct call_
{
struct list_head *head = &__get_cpu_var(softirq_work_list[softirq]);
+ if (softirq == SCHED_SOFTIRQ) {
+ raise_softirq_irqoff(softirq);
+ return;
+ }
+
list_add_tail(&cp->list, head);
/* Trigger the softirq only if the list was previously empty. */
next prev parent reply other threads:[~2010-05-17 19:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 18:27 [patch 0/7] sched: change nohz idle load balancing logic to push model Suresh Siddha
2010-05-17 18:27 ` [patch 1/7] softirq: Add a no local fallback option to send_remote_softirq Suresh Siddha
2010-05-17 18:27 ` [patch 2/7] softirq: add init_remote_softirq_csd() Suresh Siddha
2010-05-17 18:27 ` Suresh Siddha [this message]
2010-05-20 8:12 ` [patch 3/7] softirq: avoid softirq_work_list for SCHED_SOFTIRQ when sent remotely Peter Zijlstra
2010-05-20 8:14 ` David Miller
2010-05-20 8:23 ` Jens Axboe
2010-05-20 8:29 ` Peter Zijlstra
2010-05-20 9:18 ` David Miller
2010-05-17 18:27 ` [patch 4/7] sched: Change nohz ilb logic from pull to push model Suresh Siddha
2010-06-01 23:47 ` Vaidyanathan Srinivasan
2010-06-02 22:27 ` Suresh Siddha
2010-05-17 18:27 ` [patch 5/7] sched: Change select_nohz_load_balancer to return void Suresh Siddha
2010-05-17 18:27 ` [patch 6/7] sched: change nohz.load_balancer to be nr_cpu_ids based Suresh Siddha
2010-05-20 9:49 ` Peter Zijlstra
2010-05-17 18:27 ` [patch 7/7] timers: use nearest busy cpu for migrating timers from an idle cpu Suresh Siddha
2010-06-01 23:37 ` Vaidyanathan Srinivasan
2010-06-02 22:02 ` Suresh Siddha
2010-05-17 22:39 ` [patch 0/7] sched: change nohz idle load balancing logic to push model Nigel Cunningham
2010-05-19 9:19 ` Dominik Brodowski
2010-05-20 10:50 ` Peter Zijlstra
2010-05-22 0:09 ` Suresh Siddha
2010-05-31 9:17 ` Peter Zijlstra
2010-06-09 10:13 ` [tip:sched/core] sched: Change " tip-bot for Venkatesh Pallipadi
2010-05-20 11:07 ` [patch 0/7] sched: change " Nigel Cunningham
2010-05-20 11:17 ` Dominik Brodowski
2010-05-20 11:35 ` Nigel Cunningham
2010-05-20 12:13 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517184027.777058425@sbs-t61.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=arjan@linux.jf.intel.com \
--cc=davem@davemloft.net \
--cc=ego@in.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@elte.hu \
--cc=ncunningham@crca.org.au \
--cc=peterz@infradead.org \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®