Re: [PATCH] kbuild: Clean up and speed up the localversion logic

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Jun 17, 2010 at 04:05:05PM -0700, David Rientjes wrote:
> On Thu, 17 Jun 2010, Michal Marek wrote:
> 
> > Now that we run scripts/setlocalversion during every build, it makes
> > sense to move all the localversion logic there. This cleans up the
> > toplevel Makefile and also makes sure that the script is called only
> > once in 'make prepare' (previously, it would be called every time due to
> > a variable expansion in an ifneq statement). No user-visible change is
> > intended, unless one runs the setlocalversion script directly.
> > 
> > Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: David Rientjes <rientjes@google.com>
> > Cc: Greg Thelen <gthelen@google.com>
> > Cc: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>
> > Signed-off-by: Michal Marek <mmarek@suse.cz>
> > ---
> > 
> > I tried to test this in various scenarios, but if anyone of you could give
> > it a try, that would be great. The patch is against 2.6.35-rc3.
> > 
> 
> I agree it would be better to move this to scripts/setlocalversion, thanks 
> for looking into it.  I'll put this into my build cycles and see if it 
> causes any issues in my workflow that is known to be good with 2.6.35-rc3.  
> Since this is 2.6.36 material, it seems like we have some time.

No, I am sorry, it is not .36 material as the building on remote box was
messed up in .35 cycle.

-- 
Dmitry