mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Greg Thelen <gthelen@google.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Running make install over sshfs is painful now
Date: Tue, 15 Jun 2010 13:32:29 +0200	[thread overview]
Message-ID: <4C1764CD.3080402@suse.cz> (raw)
In-Reply-To: <20100607065324.GA25590@core.coreip.homeip.net>

On 7.6.2010 08:53, Dmitry Torokhov wrote:
> Hi,
> 
> With the following commit running "make modules_install install" over
> sshfs (and I suppose nfs) is extremely painful:
> 
> commit fb994ecc2b1c214951366c2ba5d8b121f0010d1f
> Author: Greg Thelen <gthelen@google.com>
> Date:   Wed May 5 10:41:44 2010 -0700
> 
>     kbuild: Fix checking of scm-identifier variable
...

Commit 85a256d8 and this one just exposed a problem we had before with
CONFIG_LOCALVERSION_AUTO, namely that the Makefile computes the release
string on _every_ invocation:

$ strace -feexecve make help 2>&1 | grep -v ' -1 ' | grep git
[pid 13788] execve("/usr/bin/git", ["git", "rev-parse", "--verify",
"--short", "HEAD"], [/* 88 vars */]) = 0
[pid 13790] execve("/usr/bin/git", ["git", "describe", "--exact-match"],
[/* 88 vars */]) = 0
[pid 13792] execve("/usr/bin/git", ["git", "describe"], [/* 88 vars */]) = 0
[pid 13795] execve("/usr/bin/git", ["git", "config", "--get",
"svn-remote.svn.url"], [/* 88 vars */]) = 0
[pid 13796] execve("/usr/bin/git", ["git", "update-index", "--refresh",
"--unmerged"], [/* 88 vars */]) = 0
[pid 13797] execve("/usr/bin/git", ["git", "diff-index", "--name-only",
"HEAD"], [/* 88 vars */]Process 13786 suspended

> Any cfhance we could generate the tag at compile time
> as opposed to install time?

The Makefile already stores the string in include/config/kernel.release
during 'make prepare', but it is nevertheless recomputed every time.
Need to clean this up.

Michal

  reply	other threads:[~2010-06-15 11:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07  6:53 Dmitry Torokhov
2010-06-15 11:32 ` Michal Marek [this message]
2010-06-17 13:40   ` [PATCH] kbuild: Clean up and speed up the localversion logic Michal Marek
2010-06-17 23:05     ` David Rientjes
2010-06-18  5:25       ` Dmitry Torokhov
2010-06-18  5:55     ` Dmitry Torokhov
2010-06-29 21:54       ` Dmitry Torokhov
2010-06-30 14:51         ` Michal Marek
2010-06-22 10:44     ` Nico Schottelius
2010-06-22 11:13       ` Michal Marek
2010-06-22 11:25         ` Nico Schottelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1764CD.3080402@suse.cz \
    --to=mmarek@suse.cz \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gthelen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome