From: Michal Marek <mmarek@suse.cz>
To: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Greg Thelen <gthelen@google.com>
Subject: Re: [PATCH] kbuild: Clean up and speed up the localversion logic
Date: Tue, 22 Jun 2010 13:13:55 +0200 [thread overview]
Message-ID: <4C209AF3.2070305@suse.cz> (raw)
In-Reply-To: <20100622104412.GB9779@ethz.ch>
On 22.6.2010 12:44, Nico Schottelius wrote:
> Michal Marek [Thu, Jun 17, 2010 at 03:40:38PM +0200]:
>> -cd "${1:-.}" || usage
>> +scm_only=false
>> +srctree=.
>> +if test "$1" = "--scm-only"; then
>> + scm_only=true
>> + shift
>> +fi
>> +if test $# -gt 0; then
>> + srctree=$1
>
> You probably want
>
> srctree="$1"
>
> to catch spaces and co. in the path.
That's the same, the value in variable assignment is not subject to word
splitting.
> Otherwise I just had a quick view over it, but seems to look good.
Thanks!
/me is now wondering if it's ok to push this for 2.6.35. At least, there
were no bugreports from linux-next users so far.
Michal
next prev parent reply other threads:[~2010-06-22 11:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 6:53 Running make install over sshfs is painful now Dmitry Torokhov
2010-06-15 11:32 ` Michal Marek
2010-06-17 13:40 ` [PATCH] kbuild: Clean up and speed up the localversion logic Michal Marek
2010-06-17 23:05 ` David Rientjes
2010-06-18 5:25 ` Dmitry Torokhov
2010-06-18 5:55 ` Dmitry Torokhov
2010-06-29 21:54 ` Dmitry Torokhov
2010-06-30 14:51 ` Michal Marek
2010-06-22 10:44 ` Nico Schottelius
2010-06-22 11:13 ` Michal Marek [this message]
2010-06-22 11:25 ` Nico Schottelius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C209AF3.2070305@suse.cz \
--to=mmarek@suse.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nico-linuxsetlocalversion@schottelius.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome