From: Christoph Hellwig <hch@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bill Davidsen <davidsen@tmr.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [regression] Crash in wb_clear_pending()
Date: Tue, 6 Jul 2010 21:47:34 -0400 [thread overview]
Message-ID: <20100707014734.GA2950@infradead.org> (raw)
In-Reply-To: <20100706064733.GA12382@elte.hu>
On Tue, Jul 06, 2010 at 08:47:33AM +0200, Ingo Molnar wrote:
> Yeah, i agree - especially since the smaller patch is still pretty large (not
> a oneliner), plus it does not appear that the precise failure mode is fully
> understood either.
The two failure modes we saw are very precicely understood:
- access to ->state after it's been freed
- access to ->state after the caller which has the bdi_work struct on
stack has been woken up.
But I seriously fear that there are even more dragons hidden in this
maze of bit wakeups and rcu, so replacing it with a proper completion
seems by far safer to me.
next prev parent reply other threads:[~2010-07-07 1:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 3:44 Linux 2.6.35-rc4 Linus Torvalds
2010-07-05 8:55 ` [regression] Crash in wb_clear_pending() (was: Linux 2.6.35-rc4) Ingo Molnar
2010-07-05 16:40 ` Christoph Hellwig
2010-07-05 17:11 ` Ingo Molnar
2010-07-05 17:14 ` Ingo Molnar
2010-07-05 18:20 ` Christoph Hellwig
2010-07-05 19:24 ` [regression] Crash in wb_clear_pending() Jens Axboe
2010-07-05 19:32 ` Christoph Hellwig
2010-07-05 19:45 ` Jens Axboe
2010-07-05 21:19 ` Bill Davidsen
2010-07-05 23:34 ` Linus Torvalds
2010-07-06 6:25 ` Jens Axboe
2010-07-06 6:49 ` Ingo Molnar
2010-07-06 6:47 ` Ingo Molnar
2010-07-06 6:50 ` Jens Axboe
2010-07-06 6:56 ` Ingo Molnar
2010-07-07 1:47 ` Christoph Hellwig [this message]
2010-07-05 10:22 ` Linux 2.6.35-rc4 Xiaotian Feng
2010-07-09 21:43 ` Linus Torvalds
2010-07-05 21:25 ` Linux 2.6.35-rc4 - CONFIG_LOCALVERSION ignored? Rafael J. Wysocki
2010-07-05 0:39 ` linux-next: build failure after merge of the kbuild-current tree Stephen Rothwell
2010-07-05 21:43 ` Linux 2.6.35-rc4 - CONFIG_LOCALVERSION ignored? Michal Marek
2010-07-06 18:29 ` Rafael J. Wysocki
2010-07-07 1:32 ` Stephen Rothwell
2010-07-12 16:58 ` Benny Halevy
2010-07-12 17:20 ` Linus Torvalds
2010-07-12 17:34 ` Benny Halevy
2010-07-09 14:21 ` Yet another 2.6.35 regression (AGP)? Woody Suwalski
2010-07-09 15:58 ` Jesse Barnes
2010-07-09 16:27 ` Woody Suwalski
2010-07-09 17:49 ` Jesse Barnes
2010-07-12 15:28 ` Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707014734.GA2950@infradead.org \
--to=hch@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome