mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Bill Davidsen <davidsen@tmr.com>,
	Christoph Hellwig <hch@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [regression] Crash in wb_clear_pending()
Date: Tue, 06 Jul 2010 08:25:46 +0200	[thread overview]
Message-ID: <4C32CC6A.3070004@kernel.dk> (raw)
In-Reply-To: <AANLkTinLrbQNv9uKYZCAKS-kFPSdle3fvAMzjI77BCu2@mail.gmail.com>

On 2010-07-06 01:34, Linus Torvalds wrote:
> On Mon, Jul 5, 2010 at 2:19 PM, Bill Davidsen <davidsen@tmr.com> wrote:
>>
>> Absent a small fix, and given that the big fix has a lot more testing than
>> any new patch might, in this case the quickie might be undesirable.
>> Particularly since posters here seem sure that code will be replaced in the
>> next version anyway, and lightly tested patch to obsolete code is actually
>> less conservative.
> 
> I have to agree. Especially as the "big patch" just removes the
> fragile code that caused the problem in the first place. So in this
> case I do suspect that the bigger patch ends up being the safer one.

OK, it's up to you.

> But I obviously don't actually see the problem, so it would be good to
> get confirmation that Christoph's patch actually fixes things first.
> Ingo, does the one in this thread apply for you?

I'll update for-linus, Ingo can try that.

-- 
Jens Axboe


  reply	other threads:[~2010-07-06  6:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  3:44 Linux 2.6.35-rc4 Linus Torvalds
2010-07-05  8:55 ` [regression] Crash in wb_clear_pending() (was: Linux 2.6.35-rc4) Ingo Molnar
2010-07-05 16:40   ` Christoph Hellwig
2010-07-05 17:11     ` Ingo Molnar
2010-07-05 17:14       ` Ingo Molnar
2010-07-05 18:20         ` Christoph Hellwig
2010-07-05 19:24           ` [regression] Crash in wb_clear_pending() Jens Axboe
2010-07-05 19:32             ` Christoph Hellwig
2010-07-05 19:45               ` Jens Axboe
2010-07-05 21:19             ` Bill Davidsen
2010-07-05 23:34               ` Linus Torvalds
2010-07-06  6:25                 ` Jens Axboe [this message]
2010-07-06  6:49                   ` Ingo Molnar
2010-07-06  6:47                 ` Ingo Molnar
2010-07-06  6:50                   ` Jens Axboe
2010-07-06  6:56                     ` Ingo Molnar
2010-07-07  1:47                   ` Christoph Hellwig
2010-07-05 10:22 ` Linux 2.6.35-rc4 Xiaotian Feng
2010-07-09 21:43   ` Linus Torvalds
2010-07-05 21:25 ` Linux 2.6.35-rc4 - CONFIG_LOCALVERSION ignored? Rafael J. Wysocki
2010-07-05  0:39   ` linux-next: build failure after merge of the kbuild-current tree Stephen Rothwell
2010-07-05 21:43     ` Linux 2.6.35-rc4 - CONFIG_LOCALVERSION ignored? Michal Marek
2010-07-06 18:29       ` Rafael J. Wysocki
2010-07-07  1:32         ` Stephen Rothwell
2010-07-12 16:58   ` Benny Halevy
2010-07-12 17:20     ` Linus Torvalds
2010-07-12 17:34       ` Benny Halevy
2010-07-09 14:21 ` Yet another 2.6.35 regression (AGP)? Woody Suwalski
2010-07-09 15:58   ` Jesse Barnes
2010-07-09 16:27     ` Woody Suwalski
2010-07-09 17:49       ` Jesse Barnes
2010-07-12 15:28   ` Maciej Rutecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C32CC6A.3070004@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=davidsen@tmr.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome