* [PATCH] Fix the declaration of sys_execve() in asm-generic/syscalls.h
@ 2010-08-18 17:55 David Howells
2010-08-18 20:44 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2010-08-18 17:55 UTC (permalink / raw)
To: tony.luck
Cc: torvalds, akpm, xiyou.wangcong, ralf, rmk+kernel, linux-kernel,
David Howells
Fix the declaration of sys_execve() in asm-generic/syscalls.h to have various
consts applied to its pointers.
Signed-off-by: David Howells <dhowells@redhat.com>
---
include/asm-generic/syscalls.h | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/asm-generic/syscalls.h b/include/asm-generic/syscalls.h
index df84e3b..d89dec8 100644
--- a/include/asm-generic/syscalls.h
+++ b/include/asm-generic/syscalls.h
@@ -23,8 +23,10 @@ asmlinkage long sys_vfork(struct pt_regs *regs);
#endif
#ifndef sys_execve
-asmlinkage long sys_execve(char __user *filename, char __user * __user *argv,
- char __user * __user *envp, struct pt_regs *regs);
+asmlinkage long sys_execve(const char __user *filename,
+ const char __user *const __user *argv,
+ const char __user *const __user *envp,
+ struct pt_regs *regs);
#endif
#ifndef sys_mmap2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix the declaration of sys_execve() in asm-generic/syscalls.h
2010-08-18 17:55 [PATCH] Fix the declaration of sys_execve() in asm-generic/syscalls.h David Howells
@ 2010-08-18 20:44 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2010-08-18 20:44 UTC (permalink / raw)
To: David Howells
Cc: tony.luck, torvalds, xiyou.wangcong, ralf, rmk+kernel, linux-kernel
On Wed, 18 Aug 2010 18:55:33 +0100
David Howells <dhowells@redhat.com> wrote:
> Fix the declaration of sys_execve() in asm-generic/syscalls.h to have various
> consts applied to its pointers.
>
crappy changelog :(
> ---
>
> include/asm-generic/syscalls.h | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/asm-generic/syscalls.h b/include/asm-generic/syscalls.h
> index df84e3b..d89dec8 100644
> --- a/include/asm-generic/syscalls.h
> +++ b/include/asm-generic/syscalls.h
> @@ -23,8 +23,10 @@ asmlinkage long sys_vfork(struct pt_regs *regs);
> #endif
>
> #ifndef sys_execve
> -asmlinkage long sys_execve(char __user *filename, char __user * __user *argv,
> - char __user * __user *envp, struct pt_regs *regs);
> +asmlinkage long sys_execve(const char __user *filename,
> + const char __user *const __user *argv,
> + const char __user *const __user *envp,
> + struct pt_regs *regs);
> #endif
>
> #ifndef sys_mmap2
Is this recent breakage?
In what way does the problem exhibit itself?
If we know these things we can then work out if the patch is needed in
2.6.36 and -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-18 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-18 17:55 [PATCH] Fix the declaration of sys_execve() in asm-generic/syscalls.h David Howells
2010-08-18 20:44 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®