PATCH : linux-2.6.35.4 drivers pcmcia cs.c

PATCH : linux-2.6.35.4 drivers pcmcia cs.c

[guillermo arias]

summary:enable cardbus cards in IBM ThinkPad 770Z

Signed-off-by:G. Arias R.<papaguillee18@gmail.com>
Date:Sun Oct 31 03:31:28 GMT-8 2010
---------------------------------------------------
--- /src/linux-2.6.35.4/drivers/pcmcia/cs.c.orig        2010-10-29
09:51:04.000000000 +0800
+++ /src/linux-2.6.35.4/drivers/pcmcia/cs.c     2010-10-01
20:54:04.000000000 +0800
@@ -396,7 +396,7 @@ static int socket_setup(struct pcmcia_so
        }

        if (status & SS_CARDBUS) {
-               if (!(skt->features & SS_CAP_CARDBUS)) {
+               if (!(skt->features || SS_CAP_CARDBUS)) {
                        dev_printk(KERN_ERR, &skt->dev,
                                "cardbus cards are not supported.\n");
                        return -EINVAL;

Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c

[Dominik Brodowski]

Hi,

indeed, on a IBM ThinkPad 770Z there seems to be some bug -- the CardBus
hardware doesn't tell the OS that it is CardBus capable. However, your
patch isn't correct -- it would enable CardBus on all PCMCIA bridges
unconditionally. Therefore, I'd need some more input for a proper patch:

1) Did CardBus cards work on any other kernel?

2) What's the output of "lspci -n -v"

3) What's the output of "sudo lspcmcia -vvv"

4) Are there any BIOS options you may toggle to enable CardBus?

Thanks & best wishes,

	Dominik

Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c

[Peter Stuge]

Dominik Brodowski wrote:
> indeed, on a IBM ThinkPad 770Z there seems to be some bug -- the CardBus
> hardware doesn't tell the OS that it is CardBus capable.

What hardware is this, and how would it tell the OS?

Is it certain that the hardware *is* actually cardbus capable?


> 2) What's the output of "lspci -n -v"
> 3) What's the output of "sudo lspcmcia -vvv"

Yes please.


> 4) Are there any BIOS options you may toggle to enable CardBus?


//Peter

Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c

[guillermo arias]

To Dominic Brodowski :.
> it would enable CardBus on all PCMCIA bridges .
comment :.
"if (!(skt->features || SS_CAP_CARDBUS))" : refuse to enable in any
error(1) condition from "pc or kernel" .

To Peter Stuge :.
>Is it certain that the hardware *is* actually cardbus capable? .
comment :.
was probed with vpn .

Thanks to you .

//Guillermo



On 11/2/10, Peter Stuge <peter@stuge.se> wrote:
> Dominik Brodowski wrote:
>> indeed, on a IBM ThinkPad 770Z there seems to be some bug -- the CardBus
>> hardware doesn't tell the OS that it is CardBus capable.
>
> What hardware is this, and how would it tell the OS?
>
> Is it certain that the hardware *is* actually cardbus capable?
>
>
>> 2) What's the output of "lspci -n -v"
>> 3) What's the output of "sudo lspcmcia -vvv"
>
> Yes please.
>
>
>> 4) Are there any BIOS options you may toggle to enable CardBus?
>
>
> //Peter
>

Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c

[Dominik Brodowski]

Hey,

On Tue, Nov 02, 2010 at 03:26:42PM +0800, guillermo arias wrote:
> To Dominic Brodowski :.
> > it would enable CardBus on all PCMCIA bridges .
> comment :.
> "if (!(skt->features || SS_CAP_CARDBUS))" : refuse to enable in any
> error(1) condition from "pc or kernel" .

No, "if (!((True or False) || True))" => "if (!((True))" => "if False",
which means we enable CardBus unconditionally if your patch is used.

> To Peter Stuge :.
> >Is it certain that the hardware *is* actually cardbus capable? .
> comment :.
> was probed with vpn .
VPN?

Also, 

> >> 2) What's the output of "lspci -n -v"
> >> 3) What's the output of "sudo lspcmcia -vvv"
> >> 4) Are there any BIOS options you may toggle to enable CardBus?

Best,
	Dominik

Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c

[guillermo arias]

thanks for your time effort and dedication to us .

To Dominic Brodowski :.
> "if (!((True or False) || True))" => "if (!((True))" => "if False" .
It is an logical true , but if no_error=0 and error=1 the result of :.
# echo "$(( ! $(( 0 || 0 )) ))"
# 1 # not bypased from the main secuence .

To Peter Stuge .
> VPN?
correction :  "was probed with vnc ."
> Also .
> > >> 2) What's the output of "lspci -n -v"
> > >> 3) What's the output of "sudo lspcmcia -vvv"
in this little "Quick Replay" window if an huge text is inserted , i
can't control it .
> > >> 4) Are there any BIOS options you may toggle to enable CardBus? .
no .

sorry gentlemans but i try to do my best .
//gar ; from Venezuela in an 56Kbauds pot https connection .