* PATCH : linux-2.6.35.4 drivers pcmcia cs.c
@ 2010-10-31 8:15 guillermo arias
2010-11-01 16:05 ` Dominik Brodowski
0 siblings, 1 reply; 6+ messages in thread
From: guillermo arias @ 2010-10-31 8:15 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
summary:enable cardbus cards in IBM ThinkPad 770Z
Signed-off-by:G. Arias R.<papaguillee18@gmail.com>
Date:Sun Oct 31 03:31:28 GMT-8 2010
---------------------------------------------------
--- /src/linux-2.6.35.4/drivers/pcmcia/cs.c.orig 2010-10-29
09:51:04.000000000 +0800
+++ /src/linux-2.6.35.4/drivers/pcmcia/cs.c 2010-10-01
20:54:04.000000000 +0800
@@ -396,7 +396,7 @@ static int socket_setup(struct pcmcia_so
}
if (status & SS_CARDBUS) {
- if (!(skt->features & SS_CAP_CARDBUS)) {
+ if (!(skt->features || SS_CAP_CARDBUS)) {
dev_printk(KERN_ERR, &skt->dev,
"cardbus cards are not supported.\n");
return -EINVAL;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c
2010-10-31 8:15 PATCH : linux-2.6.35.4 drivers pcmcia cs.c guillermo arias
@ 2010-11-01 16:05 ` Dominik Brodowski
2010-11-01 22:00 ` Peter Stuge
0 siblings, 1 reply; 6+ messages in thread
From: Dominik Brodowski @ 2010-11-01 16:05 UTC (permalink / raw)
To: guillermo arias; +Cc: linux-kernel, torvalds, linux-pcmcia
Hi,
indeed, on a IBM ThinkPad 770Z there seems to be some bug -- the CardBus
hardware doesn't tell the OS that it is CardBus capable. However, your
patch isn't correct -- it would enable CardBus on all PCMCIA bridges
unconditionally. Therefore, I'd need some more input for a proper patch:
1) Did CardBus cards work on any other kernel?
2) What's the output of "lspci -n -v"
3) What's the output of "sudo lspcmcia -vvv"
4) Are there any BIOS options you may toggle to enable CardBus?
Thanks & best wishes,
Dominik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c
2010-11-01 16:05 ` Dominik Brodowski
@ 2010-11-01 22:00 ` Peter Stuge
2010-11-02 7:26 ` guillermo arias
0 siblings, 1 reply; 6+ messages in thread
From: Peter Stuge @ 2010-11-01 22:00 UTC (permalink / raw)
To: guillermo arias, linux-kernel, torvalds, linux-pcmcia
Dominik Brodowski wrote:
> indeed, on a IBM ThinkPad 770Z there seems to be some bug -- the CardBus
> hardware doesn't tell the OS that it is CardBus capable.
What hardware is this, and how would it tell the OS?
Is it certain that the hardware *is* actually cardbus capable?
> 2) What's the output of "lspci -n -v"
> 3) What's the output of "sudo lspcmcia -vvv"
Yes please.
> 4) Are there any BIOS options you may toggle to enable CardBus?
//Peter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c
2010-11-01 22:00 ` Peter Stuge
@ 2010-11-02 7:26 ` guillermo arias
2010-11-03 14:00 ` Dominik Brodowski
0 siblings, 1 reply; 6+ messages in thread
From: guillermo arias @ 2010-11-02 7:26 UTC (permalink / raw)
To: guillermo arias, linux-kernel, torvalds, linux-pcmcia
To Dominic Brodowski :.
> it would enable CardBus on all PCMCIA bridges .
comment :.
"if (!(skt->features || SS_CAP_CARDBUS))" : refuse to enable in any
error(1) condition from "pc or kernel" .
To Peter Stuge :.
>Is it certain that the hardware *is* actually cardbus capable? .
comment :.
was probed with vpn .
Thanks to you .
//Guillermo
On 11/2/10, Peter Stuge <peter@stuge.se> wrote:
> Dominik Brodowski wrote:
>> indeed, on a IBM ThinkPad 770Z there seems to be some bug -- the CardBus
>> hardware doesn't tell the OS that it is CardBus capable.
>
> What hardware is this, and how would it tell the OS?
>
> Is it certain that the hardware *is* actually cardbus capable?
>
>
>> 2) What's the output of "lspci -n -v"
>> 3) What's the output of "sudo lspcmcia -vvv"
>
> Yes please.
>
>
>> 4) Are there any BIOS options you may toggle to enable CardBus?
>
>
> //Peter
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c
2010-11-02 7:26 ` guillermo arias
@ 2010-11-03 14:00 ` Dominik Brodowski
2010-11-04 10:08 ` guillermo arias
0 siblings, 1 reply; 6+ messages in thread
From: Dominik Brodowski @ 2010-11-03 14:00 UTC (permalink / raw)
To: guillermo arias; +Cc: linux-kernel, torvalds, linux-pcmcia
Hey,
On Tue, Nov 02, 2010 at 03:26:42PM +0800, guillermo arias wrote:
> To Dominic Brodowski :.
> > it would enable CardBus on all PCMCIA bridges .
> comment :.
> "if (!(skt->features || SS_CAP_CARDBUS))" : refuse to enable in any
> error(1) condition from "pc or kernel" .
No, "if (!((True or False) || True))" => "if (!((True))" => "if False",
which means we enable CardBus unconditionally if your patch is used.
> To Peter Stuge :.
> >Is it certain that the hardware *is* actually cardbus capable? .
> comment :.
> was probed with vpn .
VPN?
Also,
> >> 2) What's the output of "lspci -n -v"
> >> 3) What's the output of "sudo lspcmcia -vvv"
> >> 4) Are there any BIOS options you may toggle to enable CardBus?
Best,
Dominik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c
2010-11-03 14:00 ` Dominik Brodowski
@ 2010-11-04 10:08 ` guillermo arias
0 siblings, 0 replies; 6+ messages in thread
From: guillermo arias @ 2010-11-04 10:08 UTC (permalink / raw)
To: guillermo arias, linux-kernel, torvalds, linux-pcmcia
thanks for your time effort and dedication to us .
To Dominic Brodowski :.
> "if (!((True or False) || True))" => "if (!((True))" => "if False" .
It is an logical true , but if no_error=0 and error=1 the result of :.
# echo "$(( ! $(( 0 || 0 )) ))"
# 1 # not bypased from the main secuence .
To Peter Stuge .
> VPN?
correction : "was probed with vnc ."
> Also .
> > >> 2) What's the output of "lspci -n -v"
> > >> 3) What's the output of "sudo lspcmcia -vvv"
in this little "Quick Replay" window if an huge text is inserted , i
can't control it .
> > >> 4) Are there any BIOS options you may toggle to enable CardBus? .
no .
sorry gentlemans but i try to do my best .
//gar ; from Venezuela in an 56Kbauds pot https connection .
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-11-04 10:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-31 8:15 PATCH : linux-2.6.35.4 drivers pcmcia cs.c guillermo arias
2010-11-01 16:05 ` Dominik Brodowski
2010-11-01 22:00 ` Peter Stuge
2010-11-02 7:26 ` guillermo arias
2010-11-03 14:00 ` Dominik Brodowski
2010-11-04 10:08 ` guillermo arias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®