mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Viresh Kumar <viresh.kumar@st.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	yuanyabin1978@sina.com, linux-kernel@vger.kernel.org,
	Ben Dooks <ben-linux@fluff.org>,
	Peter Pearse <peter.pearse@arm.com>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	Alessandro Rubini <rubini@unipv.it>
Subject: Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells
Date: Wed, 22 Dec 2010 12:22:40 +0000	[thread overview]
Message-ID: <20101222122240.GB14693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20101221182037.GA4783@n2100.arm.linux.org.uk>

On Tue, Dec 21, 2010 at 06:20:37PM +0000, Russell King - ARM Linux wrote:
> Having just looked at this while trying to undo the DMA API abuses
> in the PL011 UART driver, I'm getting rather frustrated with this
> code.

Right, just tried this on the Versatile PB/926, which has a PL080.
The result is DMA errors.  This turns out to be the hard-coding of
which AHB bus is used.

You can't hard-code this information into the driver - it's part of
the bus matrix configuration.  On Versatile PB/926, the two AHB
buses have different memory maps - see DUI0224 page 3-13:

* DMA0 (which is DMA AHB M1) has access to the APB peripherals
  but not the system memory.
* DMA1 (which is DMA AHB M2) has access to the system memory but
  none of the APB peripherals.

Throwing in #ifdef's to sort this out resolves the problem on the PB/926.

Looking at the driver code too, I'm having a hard time understanding it,
probably because of the use of "master" and "slave" - I don't think this
has anything to do with which AHB master is used.  The comments against
pl08x_choose_master_bus() seem to imply that it controls which AHB master
is used, but it has no apparant effect on that.  I don't think this
function does anything like that anymore.

  parent reply	other threads:[~2010-12-22 12:23 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-11 15:27 Linus Walleij
2010-06-14  6:02 ` Viresh KUMAR
2010-06-14 13:39   ` Linus Walleij
2010-06-15  5:25     ` Viresh KUMAR
2010-06-15 20:14       ` Linus WALLEIJ
2010-06-16  3:59         ` Viresh KUMAR
2010-06-16  6:38           ` Linus Walleij
2010-06-15 10:25 ` Kukjin Kim
2010-06-15 10:45   ` Jassi Brar
2010-06-15 11:17     ` Maurus Cuelenaere
2010-06-15 11:39       ` Jassi Brar
2010-06-15 12:04         ` Maurus Cuelenaere
2010-06-15 20:55     ` Linus WALLEIJ
2010-12-21 18:20 ` Russell King - ARM Linux
2010-12-21 22:25   ` Russell King - ARM Linux
2010-12-22 12:22   ` Russell King - ARM Linux [this message]
2010-12-22 12:29   ` Russell King - ARM Linux
2010-12-22 23:45     ` Dan Williams
2010-12-22 23:54       ` Russell King - ARM Linux
2010-12-23  0:53         ` Dan Williams
2010-12-23  0:10       ` Russell King - ARM Linux
2010-12-23  1:11         ` Dan Williams
2010-12-23  1:31           ` Dan Williams
2010-12-31 21:50             ` Russell King - ARM Linux
2011-01-02  9:42               ` Dan Williams
2011-01-02 11:22                 ` Russell King - ARM Linux
2011-01-02 20:33               ` Linus Walleij
2011-01-03 11:14                 ` Russell King - ARM Linux
2010-12-23  9:18           ` Russell King - ARM Linux
2010-12-23  8:17       ` Linus Walleij
2010-12-23  8:30         ` Jassi Brar
2010-12-23 12:30         ` Russell King - ARM Linux
2010-12-28  0:33           ` Linus Walleij
2011-01-01 15:15       ` Russell King - ARM Linux
2011-01-02 20:29         ` Linus Walleij
2014-03-10 13:56         ` David Woodhouse
2014-03-10 14:11           ` Arnd Bergmann
2014-03-10 14:27             ` David Woodhouse
2014-03-10 14:40               ` Arnd Bergmann
2014-03-10 14:32           ` Russell King - ARM Linux
2014-03-10 14:52             ` David Woodhouse
2014-03-13  8:17               ` Linus Walleij
2014-03-13  8:52                 ` Arnd Bergmann
2014-03-13 14:35                   ` Linus Walleij
2011-01-01 15:36       ` Russell King - ARM Linux
2011-01-03 15:19       ` Russell King - ARM Linux
2011-01-04  0:41         ` Jassi Brar
2011-01-04 10:47         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101222122240.GB14693@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ben-linux@fluff.org \
    --cc=dan.j.williams@intel.com \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.pearse@arm.com \
    --cc=rubini@unipv.it \
    --cc=viresh.kumar@st.com \
    --cc=yuanyabin1978@sina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®