From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
Viresh Kumar <viresh.kumar@st.com>,
Kukjin Kim <kgene.kim@samsung.com>,
yuanyabin1978@sina.com, linux-kernel@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>,
Peter Pearse <peter.pearse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Alessandro Rubini <rubini@unipv.it>
Subject: Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells
Date: Thu, 23 Dec 2010 09:18:22 +0000 [thread overview]
Message-ID: <20101223091822.GB3636@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTimirgsuoM2che_ocrkvCZqGu6xEJjrjdmt9-69p@mail.gmail.com>
On Wed, Dec 22, 2010 at 05:11:24PM -0800, Dan Williams wrote:
> On Wed, Dec 22, 2010 at 4:10 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Wed, Dec 22, 2010 at 03:45:39PM -0800, Dan Williams wrote:
> >> 3.6 Constraints:
> >> 1/ Calls to async_<operation> are not permitted in IRQ context. Other
> >> contexts are permitted provided constraint #2 is not violated.
> >
> > BTW, this is misleading. Have the functions been renamed dma_async_xxx(),
> > eg dma_async_memcpy_buf_to_buf etc, or are you referring just to:
> >
> > async_dmaengine_get
> > async_dmaengine_put
> > async_dma_find_channel
> > async_dma_find_channel
> > async_tx_ack
> > async_tx_clear_ack
> > async_tx_test_ack
> >
> > Beware of just renaming it to dma_async_<operation> as there's other
> > functions in that namespace which may not be appropriate.
> >
> > Eg, is it really illegal to issue call dma_async_issue_pending() from
> > IRQ context? That'd make it exceedingly difficult to use the DMA
> > engine with the slave API in a lot of device drivers.
>
> This is generic offload (async_{memcpy|xor|etc...}) versus the slave
> usage confusion.
My point is that async_<operation> refers to something that doesn't
exist. What we do have:
dma_cookie_t dma_async_memcpy_buf_to_buf(struct dma_chan *chan,
void *dest, void *src, size_t len);
dma_cookie_t dma_async_memcpy_buf_to_pg(struct dma_chan *chan,
struct page *page, unsigned int offset, void *kdata, size_t len);
dma_cookie_t dma_async_memcpy_pg_to_pg(struct dma_chan *chan,
struct page *dest_pg, unsigned int dest_off, struct page *src_pg,
unsigned int src_off, size_t len);
Nothing in dmaengine.h matches 'async_xor', so that suggests it's
incomplete. There's another problem with referring to them as
dma_async_<operation> because we also have:
static inline void dma_async_issue_pending(struct dma_chan *chan)
#define dma_async_memcpy_issue_pending(chan) dma_async_issue_pending(chan)
static inline enum dma_status dma_async_is_tx_complete(struct dma_chan *chan,
dma_cookie_t cookie, dma_cookie_t *last, dma_cookie_t *used)
#define dma_async_memcpy_complete(chan, cookie, last, used)\
static inline enum dma_status dma_async_is_complete(dma_cookie_t cookie,
dma_cookie_t last_complete, dma_cookie_t last_used)
int dma_async_device_register(struct dma_device *device);
void dma_async_device_unregister(struct dma_device *device);
So just referring to dma_async_<operation> will also be confusing.
There's also a bunch of other async_* named functions which makes it
look like these are what's being referred to (see the list above).
So, the documentation is confusing.
Maybe it would be better to refer to struct dma_device's device_prep_dma_*
methods and anything which calls them, with the exception of
device_prep_dma_cyclic? (Shouldn't that be device_prep_slave_cyclic?)
next prev parent reply other threads:[~2010-12-23 9:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 15:27 Linus Walleij
2010-06-14 6:02 ` Viresh KUMAR
2010-06-14 13:39 ` Linus Walleij
2010-06-15 5:25 ` Viresh KUMAR
2010-06-15 20:14 ` Linus WALLEIJ
2010-06-16 3:59 ` Viresh KUMAR
2010-06-16 6:38 ` Linus Walleij
2010-06-15 10:25 ` Kukjin Kim
2010-06-15 10:45 ` Jassi Brar
2010-06-15 11:17 ` Maurus Cuelenaere
2010-06-15 11:39 ` Jassi Brar
2010-06-15 12:04 ` Maurus Cuelenaere
2010-06-15 20:55 ` Linus WALLEIJ
2010-12-21 18:20 ` Russell King - ARM Linux
2010-12-21 22:25 ` Russell King - ARM Linux
2010-12-22 12:22 ` Russell King - ARM Linux
2010-12-22 12:29 ` Russell King - ARM Linux
2010-12-22 23:45 ` Dan Williams
2010-12-22 23:54 ` Russell King - ARM Linux
2010-12-23 0:53 ` Dan Williams
2010-12-23 0:10 ` Russell King - ARM Linux
2010-12-23 1:11 ` Dan Williams
2010-12-23 1:31 ` Dan Williams
2010-12-31 21:50 ` Russell King - ARM Linux
2011-01-02 9:42 ` Dan Williams
2011-01-02 11:22 ` Russell King - ARM Linux
2011-01-02 20:33 ` Linus Walleij
2011-01-03 11:14 ` Russell King - ARM Linux
2010-12-23 9:18 ` Russell King - ARM Linux [this message]
2010-12-23 8:17 ` Linus Walleij
2010-12-23 8:30 ` Jassi Brar
2010-12-23 12:30 ` Russell King - ARM Linux
2010-12-28 0:33 ` Linus Walleij
2011-01-01 15:15 ` Russell King - ARM Linux
2011-01-02 20:29 ` Linus Walleij
2014-03-10 13:56 ` David Woodhouse
2014-03-10 14:11 ` Arnd Bergmann
2014-03-10 14:27 ` David Woodhouse
2014-03-10 14:40 ` Arnd Bergmann
2014-03-10 14:32 ` Russell King - ARM Linux
2014-03-10 14:52 ` David Woodhouse
2014-03-13 8:17 ` Linus Walleij
2014-03-13 8:52 ` Arnd Bergmann
2014-03-13 14:35 ` Linus Walleij
2011-01-01 15:36 ` Russell King - ARM Linux
2011-01-03 15:19 ` Russell King - ARM Linux
2011-01-04 0:41 ` Jassi Brar
2011-01-04 10:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223091822.GB3636@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ben-linux@fluff.org \
--cc=dan.j.williams@intel.com \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.pearse@arm.com \
--cc=rubini@unipv.it \
--cc=viresh.kumar@st.com \
--cc=yuanyabin1978@sina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®