mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kosaki.motohiro@jp.fujitsu.com,
	"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
	Minchan Kim <minchan.kim@gmail.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
	linux-mm <linux-mm@kvack.org>, Andrey Vagin <avagin@openvz.org>,
	Hugh Dickins <hughd@google.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 2/5] Revert "oom: give the dying task a higher priority"
Date: Tue, 29 Mar 2011 11:46:33 +0900 (JST)	[thread overview]
Message-ID: <20110329114703.C088.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1301318293.4859.19.camel@twins>

Hi

> > I mean, in the context of SCHED_OTHER tasks would it really help the dying
> > task to be scheduled sooner to release its resources? 
> 
> That very much depends on how all this stuff works, I guess if everybody
> serializes on OOM and only the first will actually kill a task and all
> the waiting tasks will try to allocate a page again before also doing
> the OOM thing, and the pending tasks are woken after the OOM target task
> has completed dying.. then I don't see much point in boosting things,
> since everybody interested in memory will block and eventually only the
> dying task will be left running.

Probably I can answer this question. When OOM occur, kernel has very a
few pages (typically 10 - 100). but not 0. therefore bloody page-in vs
page-out battle (aka allocation vs free battle) is running.

IOW, While we have multiple cpu or per-cpu page queue, we don't see
page cache become completely 0.

Therefore, not killed task doesn't sleep completely. page-out may have
very small allocation successful chance. (but almostly it's fail. pages
are stealed by another task)

Before Luis's patch, kernel livelock on oom may be solved within 30min,
but after his patch, it's solved within 1 second. that's big different
for human response time. That's the test result.

Thanks.



  parent reply	other threads:[~2011-03-29  2:46 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15  1:49 Linux 2.6.38 Linus Torvalds
2011-03-15  3:13 ` David Rientjes
2011-03-15  4:06   ` Steven Rostedt
2011-03-15  4:14   ` Linus Torvalds
2011-03-15  4:29     ` David Rientjes
2011-03-15  4:33   ` Andrew Morton
2011-03-15  4:50     ` David Rientjes
2011-03-15  6:21       ` Andrew Morton
2011-03-16  9:09         ` KOSAKI Motohiro
2011-03-22 11:04           ` [patch 0/5] oom: a few anti fork bomb patches KOSAKI Motohiro
2011-03-22 11:05             ` [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely KOSAKI Motohiro
2011-03-22 14:49               ` Minchan Kim
2011-03-23  5:21                 ` KOSAKI Motohiro
2011-03-23  6:59                   ` Minchan Kim
2011-03-23  7:13                     ` KOSAKI Motohiro
2011-03-23  8:24                       ` Minchan Kim
2011-03-23  8:44                         ` KOSAKI Motohiro
2011-03-23  9:02                           ` Minchan Kim
2011-03-24  2:11                             ` KOSAKI Motohiro
2011-03-24  2:21                               ` Andrew Morton
2011-03-24  2:48                                 ` KOSAKI Motohiro
2011-03-24  3:04                                   ` Andrew Morton
2011-03-24  5:35                                     ` KOSAKI Motohiro
2011-03-24  4:19                               ` Minchan Kim
2011-03-24  5:35                                 ` KOSAKI Motohiro
2011-03-24  5:53                                   ` Minchan Kim
2011-03-24  6:16                                     ` KOSAKI Motohiro
2011-03-24  6:32                                       ` Minchan Kim
2011-03-24  7:03                                         ` KOSAKI Motohiro
2011-03-24  7:25                                           ` Minchan Kim
2011-03-24  7:28                                             ` KOSAKI Motohiro
2011-03-24  7:34                                               ` Minchan Kim
2011-03-24  7:41                                                 ` Minchan Kim
2011-03-24  7:43                                                 ` KOSAKI Motohiro
2011-03-24  7:43                                   ` Minchan Kim
2011-03-23  7:41               ` KAMEZAWA Hiroyuki
2011-03-23  7:55                 ` KOSAKI Motohiro
2011-03-22 11:08             ` [PATCH 3/5] oom: create oom autogroup KOSAKI Motohiro
2011-03-22 23:21               ` Minchan Kim
2011-03-23  1:27                 ` KOSAKI Motohiro
2011-03-23  2:41                   ` Mike Galbraith
2011-03-22 11:08             ` [PATCH 4/5] mm: introduce wait_on_page_locked_killable KOSAKI Motohiro
2011-03-23  7:44               ` KAMEZAWA Hiroyuki
2011-03-24 15:04               ` Minchan Kim
2011-03-22 11:09             ` [PATCH 5/5] x86,mm: make pagefault killable KOSAKI Motohiro
2011-03-23  7:49               ` KAMEZAWA Hiroyuki
2011-03-23  8:09                 ` KOSAKI Motohiro
2011-03-23 14:34                   ` Linus Torvalds
2011-03-24 15:10               ` Minchan Kim
2011-03-24 17:13               ` Oleg Nesterov
2011-03-24 17:34                 ` Linus Torvalds
2011-03-28  7:00                   ` KOSAKI Motohiro
     [not found]             ` <20110322200657.B064.A69D9226@jp.fujitsu.com>
     [not found]               ` <20110323164229.6b647004.kamezawa.hiroyu@jp.fujitsu.com>
2011-03-23 13:40                 ` [PATCH 2/5] Revert "oom: give the dying task a higher priority" Luis Claudio R. Goncalves
2011-03-24  0:06                   ` KOSAKI Motohiro
2011-03-24 15:27               ` Minchan Kim
2011-03-28  9:48                 ` KOSAKI Motohiro
2011-03-28 12:28                   ` Minchan Kim
2011-03-28  9:51                 ` Peter Zijlstra
2011-03-28 12:21                   ` Minchan Kim
2011-03-28 12:28                     ` Peter Zijlstra
2011-03-28 12:40                       ` Minchan Kim
2011-03-28 13:10                         ` Luis Claudio R. Goncalves
2011-03-28 13:18                           ` Peter Zijlstra
2011-03-28 13:56                             ` Luis Claudio R. Goncalves
2011-03-29  2:46                             ` KOSAKI Motohiro [this message]
2011-03-28 13:48                           ` Minchan Kim
2011-03-15 21:08       ` Linux 2.6.38 Oleg Nesterov
2011-03-15  3:14 ` Steven Rostedt
2011-03-15  4:15   ` Linus Torvalds
2011-03-16 17:30 ` i915/kms regression after 2.6.38-rc8 (was: Re: Linux 2.6.38) Melchior FRANZ
2011-03-16 19:22   ` i915/kms regression after 2.6.38-rc8 Jiri Slaby
2011-03-16 19:43   ` i915/kms regression after 2.6.38-rc8 (was: Re: Linux 2.6.38) Chris Wilson
2011-03-16 21:09     ` i915/kms regression after 2.6.38-rc8 Melchior FRANZ
2011-03-20 18:30   ` i915/kms regression after 2.6.38-rc8 (was: Re: Linux 2.6.38) Maciej Rutecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329114703.C088.A69D9226@jp.fujitsu.com \
    --to=kosaki.motohiro@jp.fujitsu.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@openvz.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=lclaudio@uudg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=oleg@redhat.com \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®