mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Michael Leun <lkml20101129@newton.leun.net>,
	Yinghai Lu <yinghai@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	Mike Pagano <mpagano@gentoo.org>
Subject: Re: 2.6.38.2 breaks suspend to disk
Date: Thu, 31 Mar 2011 23:48:53 +0200	[thread overview]
Message-ID: <201103312348.53678.rjw@sisk.pl> (raw)
In-Reply-To: <alpine.DEB.2.00.1103311546480.16492@kaball-desktop>

On Thursday, March 31, 2011, Stefano Stabellini wrote:
> On Thu, 31 Mar 2011, Michael Leun wrote:
> > Nope, unfortunately this does not change anything (neither when
> > applying ontop of the tree resulting from bisecting, nor ontop
> > 2.6.38.2).
> > 
> > Just to make shure there was no mistake when bisecting I did
> > 
> > patch -R -p1 <~/linux-2.6.38.y.git-ff518ea26654e05d325d996f6e3a7f5f569cc2d5.txt
> > 
> > and then indeed it worked again.
> 
> This patch fixes it for me.
> 
> 
> ---
> 
> save cr4 to mmu_cr4_features at boot time
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>

Peter, Ingo, please regard this as urgent, it breaks -stable.

Thanks,
Rafael


> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 5a0484a..0943eb2 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -891,6 +891,7 @@ void __init setup_arch(char **cmdline_p)
>  		max_low_pfn = max_pfn;
>  
>  	high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
> +	mmu_cr4_features = read_cr4();
>  #endif
>  
>  	/*
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 


  parent reply	other threads:[~2011-03-31 21:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 18:32 Michael Leun
2011-03-31  5:14 ` Yinghai Lu
2011-03-31  7:05   ` Michael Leun
2011-03-31 14:48     ` Stefano Stabellini
2011-03-31 15:53       ` Michael Leun
2011-03-31 21:48       ` Rafael J. Wysocki [this message]
2011-03-31 22:20         ` Yinghai Lu
2011-04-01 11:32           ` Stefano Stabellini
2011-04-01 16:06             ` Yinghai Lu
2011-04-01 16:22               ` H. Peter Anvin
2011-04-01 17:14                 ` Yinghai Lu
2011-04-01 18:15                   ` Stefano Stabellini
2011-04-01 18:14                 ` Stefano Stabellini
2011-04-01 18:55                   ` H. Peter Anvin
2011-04-01 19:32                     ` Yinghai Lu
2011-04-01 19:36                       ` H. Peter Anvin
2011-04-01 19:54                         ` Yinghai Lu
2011-04-01 20:21                           ` H. Peter Anvin
2011-04-01 21:24                             ` Yinghai Lu
2011-04-01 21:30                               ` H. Peter Anvin
2011-04-01 21:37                                 ` Yinghai Lu
2011-04-01 21:42                                   ` H. Peter Anvin
2011-04-01 23:04                                     ` Yinghai Lu
2011-04-01 23:12                                       ` H. Peter Anvin
2011-04-02  0:10                                         ` Yinghai Lu
2011-04-01 23:54                     ` Rafael J. Wysocki
2011-04-06 20:28                       ` [tip:x86/urgent] x86, hibernate: Initialize mmu_cr4_features during boot tip-bot for H. Peter Anvin
2011-04-01  6:15         ` 2.6.38.2 breaks suspend to disk Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103312348.53678.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml20101129@newton.leun.net \
    --cc=mingo@redhat.com \
    --cc=mpagano@gentoo.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®