mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Michael Leun <lkml20101129@newton.leun.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Mike Pagano <mpagano@gentoo.org>
Subject: Re: 2.6.38.2 breaks suspend to disk
Date: Fri, 1 Apr 2011 12:32:48 +0100	[thread overview]
Message-ID: <alpine.DEB.2.00.1104011230550.16492@kaball-desktop> (raw)
In-Reply-To: <4D94FE37.8070109@kernel.org>

On Thu, 31 Mar 2011, Yinghai Lu wrote:
> Stefano, can you explain why it fixes the problem?
> 
> or original patch uncover the bug?

as I wrote in the other email, e5f15b45ddf3afa2bbbb10c7ea34fb32b6de0a0e
removes cleanup_highmap_brk_end but this function was not only dealing
with mappings but it was also setting mmu_cr4_features, therefore the
setting of mmu_cr4_features was lost.

I think the real bug is that mmu_cr4_features ended up in
cleanup_highmap_brk_end by mistake.

  reply	other threads:[~2011-04-01 11:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 18:32 Michael Leun
2011-03-31  5:14 ` Yinghai Lu
2011-03-31  7:05   ` Michael Leun
2011-03-31 14:48     ` Stefano Stabellini
2011-03-31 15:53       ` Michael Leun
2011-03-31 21:48       ` Rafael J. Wysocki
2011-03-31 22:20         ` Yinghai Lu
2011-04-01 11:32           ` Stefano Stabellini [this message]
2011-04-01 16:06             ` Yinghai Lu
2011-04-01 16:22               ` H. Peter Anvin
2011-04-01 17:14                 ` Yinghai Lu
2011-04-01 18:15                   ` Stefano Stabellini
2011-04-01 18:14                 ` Stefano Stabellini
2011-04-01 18:55                   ` H. Peter Anvin
2011-04-01 19:32                     ` Yinghai Lu
2011-04-01 19:36                       ` H. Peter Anvin
2011-04-01 19:54                         ` Yinghai Lu
2011-04-01 20:21                           ` H. Peter Anvin
2011-04-01 21:24                             ` Yinghai Lu
2011-04-01 21:30                               ` H. Peter Anvin
2011-04-01 21:37                                 ` Yinghai Lu
2011-04-01 21:42                                   ` H. Peter Anvin
2011-04-01 23:04                                     ` Yinghai Lu
2011-04-01 23:12                                       ` H. Peter Anvin
2011-04-02  0:10                                         ` Yinghai Lu
2011-04-01 23:54                     ` Rafael J. Wysocki
2011-04-06 20:28                       ` [tip:x86/urgent] x86, hibernate: Initialize mmu_cr4_features during boot tip-bot for H. Peter Anvin
2011-04-01  6:15         ` 2.6.38.2 breaks suspend to disk Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1104011230550.16492@kaball-desktop \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml20101129@newton.leun.net \
    --cc=mingo@redhat.com \
    --cc=mpagano@gentoo.org \
    --cc=rjw@sisk.pl \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®