mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <hpa@linux.intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	yinghai@kernel.org, stefano.stabellini@eu.citrix.com,
	tglx@linutronix.de, hpa@linux.intel.com, rjw@sisk.pl
Subject: [tip:x86/urgent] x86, hibernate: Initialize mmu_cr4_features during boot
Date: Wed, 6 Apr 2011 20:28:00 GMT	[thread overview]
Message-ID: <tip-4da9484bdece39ab0b098fa711e095e3e9fc8684@git.kernel.org> (raw)
In-Reply-To: <201104020154.57136.rjw@sisk.pl>

Commit-ID:  4da9484bdece39ab0b098fa711e095e3e9fc8684
Gitweb:     http://git.kernel.org/tip/4da9484bdece39ab0b098fa711e095e3e9fc8684
Author:     H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Wed, 6 Apr 2011 13:10:02 -0700
Committer:  H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 6 Apr 2011 13:10:02 -0700

x86, hibernate: Initialize mmu_cr4_features during boot

Restore the initialization of mmu_cr4_features during boot, which was
removed without comment in checkin e5f15b45ddf3afa2bbbb10c7ea34fb32b6de0a0e

x86: Cleanup highmap after brk is concluded

thereby breaking resume from hibernate.  This restores previous
functionality in approximately the same place, and corrects the
reading of %cr4 on pre-CPUID hardware (%cr4 exists if and only if
CPUID is supported.)

However, part of the problem is that the hibernate suspend/resume
sequence should manage the save/restore of %cr4 explicitly.

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <201104020154.57136.rjw@sisk.pl>
---
 arch/x86/kernel/setup.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 5a0484a..4be9b39 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -976,6 +976,11 @@ void __init setup_arch(char **cmdline_p)
 	paging_init();
 	x86_init.paging.pagetable_setup_done(swapper_pg_dir);
 
+	if (boot_cpu_data.cpuid_level >= 0) {
+		/* A CPU has %cr4 if and only if it has CPUID */
+		mmu_cr4_features = read_cr4();
+	}
+
 #ifdef CONFIG_X86_32
 	/* sync back kernel address range */
 	clone_pgd_range(initial_page_table + KERNEL_PGD_BOUNDARY,

  reply	other threads:[~2011-04-06 20:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 18:32 2.6.38.2 breaks suspend to disk Michael Leun
2011-03-31  5:14 ` Yinghai Lu
2011-03-31  7:05   ` Michael Leun
2011-03-31 14:48     ` Stefano Stabellini
2011-03-31 15:53       ` Michael Leun
2011-03-31 21:48       ` Rafael J. Wysocki
2011-03-31 22:20         ` Yinghai Lu
2011-04-01 11:32           ` Stefano Stabellini
2011-04-01 16:06             ` Yinghai Lu
2011-04-01 16:22               ` H. Peter Anvin
2011-04-01 17:14                 ` Yinghai Lu
2011-04-01 18:15                   ` Stefano Stabellini
2011-04-01 18:14                 ` Stefano Stabellini
2011-04-01 18:55                   ` H. Peter Anvin
2011-04-01 19:32                     ` Yinghai Lu
2011-04-01 19:36                       ` H. Peter Anvin
2011-04-01 19:54                         ` Yinghai Lu
2011-04-01 20:21                           ` H. Peter Anvin
2011-04-01 21:24                             ` Yinghai Lu
2011-04-01 21:30                               ` H. Peter Anvin
2011-04-01 21:37                                 ` Yinghai Lu
2011-04-01 21:42                                   ` H. Peter Anvin
2011-04-01 23:04                                     ` Yinghai Lu
2011-04-01 23:12                                       ` H. Peter Anvin
2011-04-02  0:10                                         ` Yinghai Lu
2011-04-01 23:54                     ` Rafael J. Wysocki
2011-04-06 20:28                       ` tip-bot for H. Peter Anvin [this message]
2011-04-01  6:15         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-4da9484bdece39ab0b098fa711e095e3e9fc8684@git.kernel.org \
    --to=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome