From: Jamie Iles <jamie@jamieiles.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
tglx@linutronix.de, grant.likely@secretlab.ca, arnd@arndb.de,
nico@fluxnic.net
Subject: Re: [PATCHv2 6/7] basic_mmio_gpio: support different input/output registers
Date: Fri, 8 Apr 2011 15:40:51 +0100 [thread overview]
Message-ID: <20110408144051.GF2933@pulham.picochip.com> (raw)
In-Reply-To: <20110408143641.GA25237@oksana.dev.rtsoft.ru>
On Fri, Apr 08, 2011 at 06:36:41PM +0400, Anton Vorontsov wrote:
> On Fri, Apr 08, 2011 at 03:16:50PM +0100, Jamie Iles wrote:
> [...]
> > + res_in = platform_get_resource_byname(pdev, IORESOURCE_MEM, "in");
> > + if (res_in) {
> > + bgc->reg_in = bgpio_request_and_map(&pdev->dev, res_in);
> > + if (!bgc->reg_in)
> > + return -ENOMEM;
> > + bgc->gc.get = bgpio_get_in;
> > + } else {
> > + bgc->gc.get = bgpio_get_dat;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > return 0;
> > }
>
> Hm.. will this compile?
No, I accidentally squashed patches 6 and 7 together then obviously
didn't split them properly. I'll fix this (and the spacing around the
locking and repost).
Sorry!
Jamie
next prev parent reply other threads:[~2011-04-08 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 14:16 [PATCHv2 0/7] gpio: extend basic_mmio_gpio for different controllers Jamie Iles
2011-04-08 14:16 ` [PATCHv2 1/7] basic_mmio_gpio: remove runtime width/endianness evaluation Jamie Iles
2011-04-08 14:16 ` [PATCHv2 2/7] basic_mmio_gpio: convert to platform_{get,set}_drvdata() Jamie Iles
2011-04-08 14:16 ` [PATCHv2 3/7] basic_mmio_gpio: allow overriding number of gpio Jamie Iles
2011-04-08 14:16 ` [PATCHv2 4/7] basic_mmio_gpio: request register regions Jamie Iles
2011-04-08 14:16 ` [PATCHv2 5/7] basic_mmio_gpio: detect output method at probe time Jamie Iles
2011-04-08 14:16 ` [PATCHv2 6/7] basic_mmio_gpio: support different input/output registers Jamie Iles
2011-04-08 14:36 ` Anton Vorontsov
2011-04-08 14:40 ` Jamie Iles [this message]
2011-04-08 14:46 ` Anton Vorontsov
2011-04-08 16:11 ` Jamie Iles
2011-04-08 16:26 ` Anton Vorontsov
2011-04-08 16:32 ` Jamie Iles
2011-04-08 14:16 ` [PATCHv2 7/7] basic_mmio_gpio: support direction registers Jamie Iles
2011-04-08 14:38 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408144051.GF2933@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=arnd@arndb.de \
--cc=cbouatmailru@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®