mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	tglx@linutronix.de, grant.likely@secretlab.ca, arnd@arndb.de,
	nico@fluxnic.net
Subject: Re: [PATCHv2 6/7] basic_mmio_gpio: support different input/output registers
Date: Fri, 8 Apr 2011 20:26:30 +0400	[thread overview]
Message-ID: <20110408162630.GA7354@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20110408161113.GG2933@pulham.picochip.com>

On Fri, Apr 08, 2011 at 05:11:13PM +0100, Jamie Iles wrote:
[...]
> > > +++ b/drivers/gpio/basic_mmio_gpio.c
> > > @@ -70,6 +70,7 @@ struct bgpio_chip {
> > >  	void __iomem *reg_dat;
> > >  	void __iomem *reg_set;
> > >  	void __iomem *reg_clr;
> > > +	void __iomem *reg_in;
> > 
> > Btw, I wonder if it makes sense (and more logical) for separate output/
> > input registers case to use "reg_dat" for 'input' and 'reg_set' for
> > output?
> 
> Sounds like a good idea.  Something like this?

Yep, exactly.

[...]
> +	} else if (res_set && !res_clr) {
> +		if (resource_size(res_set) != resource_size(res_dat) ||
> +		    resource_size(res_set) != bgc->bits / 8)

We derive bgc->bits from resource_size(res_dat), so '!= bgc->bits / 8'
condition is uneeded.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

  reply	other threads:[~2011-04-08 16:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 14:16 [PATCHv2 0/7] gpio: extend basic_mmio_gpio for different controllers Jamie Iles
2011-04-08 14:16 ` [PATCHv2 1/7] basic_mmio_gpio: remove runtime width/endianness evaluation Jamie Iles
2011-04-08 14:16 ` [PATCHv2 2/7] basic_mmio_gpio: convert to platform_{get,set}_drvdata() Jamie Iles
2011-04-08 14:16 ` [PATCHv2 3/7] basic_mmio_gpio: allow overriding number of gpio Jamie Iles
2011-04-08 14:16 ` [PATCHv2 4/7] basic_mmio_gpio: request register regions Jamie Iles
2011-04-08 14:16 ` [PATCHv2 5/7] basic_mmio_gpio: detect output method at probe time Jamie Iles
2011-04-08 14:16 ` [PATCHv2 6/7] basic_mmio_gpio: support different input/output registers Jamie Iles
2011-04-08 14:36   ` Anton Vorontsov
2011-04-08 14:40     ` Jamie Iles
2011-04-08 14:46   ` Anton Vorontsov
2011-04-08 16:11     ` Jamie Iles
2011-04-08 16:26       ` Anton Vorontsov [this message]
2011-04-08 16:32         ` Jamie Iles
2011-04-08 14:16 ` [PATCHv2 7/7] basic_mmio_gpio: support direction registers Jamie Iles
2011-04-08 14:38   ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110408162630.GA7354@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=arnd@arndb.de \
    --cc=grant.likely@secretlab.ca \
    --cc=jamie@jamieiles.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nico@fluxnic.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®