From: Antonio Ospite <ospite@studenti.unina.it>
To: Simon Wood <simon@mungewell.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcin Tolysz <tolysz@gmail.com>, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 1/2] sony_ff_hid_descriptor
Date: Wed, 1 Jun 2011 21:49:24 +0200 [thread overview]
Message-ID: <20110601214924.36ec42ad.ospite@studenti.unina.it> (raw)
In-Reply-To: <1306145999-15643-1-git-send-email-simon@mungewell.org>
[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]
On Mon, 23 May 2011 03:19:58 -0700
Simon Wood <simon@mungewell.org> wrote:
> This patch modifies the HID descriptor to allow the reporting of
> the accelerometers and gyro via a joystick axis.
I am going to test it tomorrow, but for now I notice that the
Signed-off-by is missing. Wait for the test before resending tho.
Plus, the short commit message can be improved a little bit, and the
long commit message could use the classic imperative form used in kernel
commit messages: "Modify the HID descriptor to...", but these are just
suggestions.
Same comments for patch 2/2.
Thanks,
Antonio
> ---
> drivers/hid/hid-sony.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
> index 936c911..5c930dc 100644
> --- a/drivers/hid/hid-sony.c
> +++ b/drivers/hid/hid-sony.c
> @@ -28,6 +28,12 @@
> #define SIXAXIS_CONTROLLER_USB (1 << 1)
> #define SIXAXIS_CONTROLLER_BT (1 << 2)
>
> +static const u8 sixaxis_rdesc_fixup[] = {
> + 0x95, 0x13, 0x09, 0x01, 0x81, 0x02, 0x95, 0x0C,
> + 0x81, 0x01, 0x75, 0x10, 0x95, 0x04, 0x26, 0xFF,
> + 0x03, 0x46, 0xFF, 0x03, 0x09, 0x01, 0x81, 0x02
> + };
> +
> struct sony_sc {
> unsigned long quirks;
> };
> @@ -43,6 +49,11 @@ static __u8 *sony_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> hid_info(hdev, "Fixing up Sony Vaio VGX report descriptor\n");
> rdesc[55] = 0x06;
> }
> + if ((sc->quirks & SIXAXIS_CONTROLLER_USB) &&
> + *rsize == 148 && rdesc[83] == 0x75) {
> + hid_info(hdev, "Fixing up Sony Sixaxis report descriptor\n");
> + memcpy((void *)&rdesc[83], (void *) &sixaxis_rdesc_fixup, sizeof(sixaxis_rdesc_fixup));
> + }
> return rdesc;
> }
>
> --
> 1.7.4.1
>
>
--
Antonio Ospite
http://ao2.it
PGP public key ID: 0x4553B001
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-06-01 19:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <80b32cfd7dc9e8afee2c4d9e21d1a7e3.squirrel@host171.canaca.com>
2011-05-23 10:19 ` Simon Wood
2011-05-23 10:19 ` [PATCH 2/2] sony_ff_byteswap_accelerometer Simon Wood
2011-06-01 19:53 ` Antonio Ospite
2011-06-01 19:49 ` Antonio Ospite [this message]
2011-06-07 13:32 ` [PATCH 1/2] sony_ff_hid_descriptor Jiri Kosina
2011-06-07 13:32 ` Jiri Kosina
2011-06-07 14:12 ` Antonio Ospite
2011-06-07 15:53 ` simon
2011-06-07 19:40 ` Antonio Ospite
2011-05-23 10:23 ` Simon Wood
2011-05-23 10:23 ` [PATCH 2/2] sony_ff_byteswap_accelerometer Simon Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601214924.36ec42ad.ospite@studenti.unina.it \
--to=ospite@studenti.unina.it \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
--cc=tolysz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®