mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonio Ospite <ospite@studenti.unina.it>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Simon Wood <simon@mungewell.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Marcin Tolysz <tolysz@gmail.com>
Subject: Re: [PATCH 1/2] sony_ff_hid_descriptor
Date: Tue, 7 Jun 2011 16:12:21 +0200	[thread overview]
Message-ID: <20110607161221.3334dcdd.ospite@studenti.unina.it> (raw)
In-Reply-To: <alpine.LNX.2.00.1106071531330.22872@pobox.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

On Tue, 7 Jun 2011 15:32:15 +0200 (CEST)
Jiri Kosina <jkosina@suse.cz> wrote:

> On Wed, 1 Jun 2011, Antonio Ospite wrote:
> 
> > On Mon, 23 May 2011 03:19:58 -0700
> > Simon Wood <simon@mungewell.org> wrote:
> > 
> > > This patch modifies the HID descriptor to allow the reporting of
> > > the accelerometers and gyro via a joystick axis.
> > 
> > I am going to test it tomorrow, but for now I notice that the
> > Signed-off-by is missing. Wait for the test before resending tho.
> > 
> > Plus, the short commit message can be improved a little bit, and the
> > long commit message could use the classic imperative form used in kernel
> > commit messages: "Modify the HID descriptor to...", but these are just
> > suggestions.
[...]

> What was the result of your testing of the patches, please?
> 

There has been an off-list discussion and I think Simon is going to send
the patches once again in a form which amends the HID descriptor even
when the Sixaxis is connected via Bluetooth.

I will retest and add the Tested-by on those.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

  parent reply	other threads:[~2011-06-07 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <80b32cfd7dc9e8afee2c4d9e21d1a7e3.squirrel@host171.canaca.com>
2011-05-23 10:19 ` Simon Wood
2011-05-23 10:19   ` [PATCH 2/2] sony_ff_byteswap_accelerometer Simon Wood
2011-06-01 19:53     ` Antonio Ospite
2011-06-01 19:49   ` [PATCH 1/2] sony_ff_hid_descriptor Antonio Ospite
2011-06-07 13:32     ` Jiri Kosina
2011-06-07 13:32       ` Jiri Kosina
2011-06-07 14:12       ` Antonio Ospite [this message]
2011-06-07 15:53       ` simon
2011-06-07 19:40         ` Antonio Ospite
2011-05-23 10:23 ` Simon Wood
2011-05-23 10:23   ` [PATCH 2/2] sony_ff_byteswap_accelerometer Simon Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110607161221.3334dcdd.ospite@studenti.unina.it \
    --to=ospite@studenti.unina.it \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@mungewell.org \
    --cc=tolysz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®