From: Francois Romieu <romieu@fr.zoreil.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/7] r8169: adjust the settings about RxConfig
Date: Tue, 12 Jul 2011 18:12:58 +0200 [thread overview]
Message-ID: <20110712161258.GA6157@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1309939088-31994-3-git-send-email-hayeswang@realtek.com>
Hayes Wang <hayeswang@realtek.com> :
> Set the init value before reset in probe function. And then just
> modify the relative bits and keep the init settings.
It breaks my old PCI Netgear 8110s (RTL_GIGA_MAC_VER_03/XID 04000000). Once
the device is up, RxConfig is changed from 0x0000e70e to 0x0000000e (missed
write ?).
Is there any side effect / objection if this patch is removed from the
series and scheduled for a later time ?
If the current working code is kept as is, the 8168c/cp would still see its
RxConfig:bit 13 (RxHalfRefetch) enabled.
--
Ueimor
next prev parent reply other threads:[~2011-07-12 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 7:58 [PATCH net-next v2 1/7] r8169: adjust some registers Hayes Wang
2011-07-06 7:58 ` [PATCH net-next v2 2/7] r8169: modify the flow of the hw reset Hayes Wang
2011-07-06 7:58 ` [PATCH net-next v2 3/7] r8169: adjust the settings about RxConfig Hayes Wang
2011-07-12 16:12 ` Francois Romieu [this message]
2011-07-13 12:16 ` hayeswang
2011-07-06 7:58 ` [PATCH net-next v2 4/7] r8169: add ERI functions Hayes Wang
2011-07-06 7:58 ` [PATCH net-next v2 5/7] r8169: support RTL8111E-VL Hayes Wang
2011-07-06 7:58 ` [PATCH net-next v2 6/7] r8169: fix wake on lan setting for non-8111E Hayes Wang
2011-07-06 7:58 ` [PATCH net-next v2 7/7] r8169: don't enable rx when shutdown Hayes Wang
2011-07-07 8:50 ` [PATCH net-next v2 1/7] r8169: adjust some registers Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712161258.GA6157@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®