RE: [PATCH net-next v2 3/7] r8169: adjust the settings about RxConfig

[hayeswang <hayeswang@realtek.com>]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

 
 Francois Romieu [mailto:romieu@fr.zoreil.com] 
> Sent: Wednesday, July 13, 2011 12:13 AM
> To: Hayeswang
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v2 3/7] r8169: adjust the 
> settings about RxConfig
> 
> Hayes Wang <hayeswang@realtek.com> :
> > Set the init value before reset in probe function. And then just 
> > modify the relative bits and keep the init settings.
> 
> It breaks my old PCI Netgear 8110s (RTL_GIGA_MAC_VER_03/XID 
> 04000000). Once the device is up, RxConfig is changed from 
> 0x0000e70e to 0x0000000e (missed write ?).
> 

I find that the RxConfig has to be set after the tx/rx is enabled for 8110S(x)
series.

> Is there any side effect / objection if this patch is removed 
> from the series and scheduled for a later time ?
> 

The original values are different from the suggested values, so I hope to apply
this patch.
Please try the attached file. It should fix this issue.
 
Best Regards,
Hayes

[-- Attachment #2: 0001-r8169-fix-the-RxConfig-couldn-t-be-written.patch --]
[-- Type: application/octet-stream, Size: 964 bytes --]

>From d291f25398cd6de2d9ef8545e70f003dd091f192 Mon Sep 17 00:00:00 2001
From: Hayes <hayeswang@realtek.com>
Date: Wed, 13 Jul 2011 11:44:06 +0800
Subject: [PATCH] r8169:fix the RxConfig couldn't be written

For 8110S, 8110SB, and 8110SC series, the initial value of RxConfig
needs to be set after the tx/rx is enabled.

Signed-off-by Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/r8169.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 19d739a..f04cd8a 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -4065,6 +4065,9 @@ static void rtl_hw_start_8169(struct net_device *dev)
 	    tp->mac_version == RTL_GIGA_MAC_VER_04)
 		RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
 
+	/* RxConfig needs to be initialized after tx/rx enable */
+	rtl_init_rxcfg(tp);
+
 	RTL_W8(EarlyTxThres, NoEarlyTx);
 
 	rtl_set_rx_max_size(ioaddr, rx_buf_sz);
-- 
1.7.3.4