* [PATCH] ext3/xattr_seciruty.c: local functions should be static
@ 2011-09-23 22:07 H Hartley Sweeten
2011-10-04 23:37 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 22:07 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-ext4, jack, akpm, adilger.kernel
Quiets the sparse noise:
warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
---
diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
index 3c218b8..3f065f8 100644
--- a/fs/ext3/xattr_security.c
+++ b/fs/ext3/xattr_security.c
@@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
void *fs_info)
{
const struct xattr *xattr;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static
2011-09-23 22:07 [PATCH] ext3/xattr_seciruty.c: local functions should be static H Hartley Sweeten
@ 2011-10-04 23:37 ` Jan Kara
2011-10-05 17:27 ` H Hartley Sweeten
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kara @ 2011-10-04 23:37 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-ext4, jack, akpm, adilger.kernel
On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.
Honza
>
> ---
>
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3c218b8..3f065f8 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
> name, value, size, flags);
> }
>
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ext3/xattr_seciruty.c: local functions should be static
2011-10-04 23:37 ` Jan Kara
@ 2011-10-05 17:27 ` H Hartley Sweeten
2011-10-05 20:18 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: H Hartley Sweeten @ 2011-10-05 17:27 UTC (permalink / raw)
To: Jan Kara; +Cc: Linux Kernel, linux-ext4, akpm, adilger.kernel
On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote:
> On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
>> Quiets the sparse noise:
>>
>> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Jan Kara <jack@suse.cz>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Here applies the same comment as to the ext2 patch - not in current
> Linus' kernel AFAICS.
These are in linux-next due to:
commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
Author: Mimi Zohar <zohar@linux.vnet.ibm.com>
Date: Mon Jun 6 15:29:25 2011 -0400
security: new security_inode_init_security API adds function callback
I can repost these after this commit hits Linus' kernel if necessary.
Thanks,
Hartley
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static
2011-10-05 17:27 ` H Hartley Sweeten
@ 2011-10-05 20:18 ` Jan Kara
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2011-10-05 20:18 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: Jan Kara, Linux Kernel, linux-ext4, akpm, adilger.kernel
On Wed 05-10-11 12:27:06, H Hartley Sweeten wrote:
> On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote:
> > On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> >> Quiets the sparse noise:
> >>
> >> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
> >>
> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >> Cc: Jan Kara <jack@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> > Here applies the same comment as to the ext2 patch - not in current
> > Linus' kernel AFAICS.
>
> These are in linux-next due to:
>
> commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
> Author: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Date: Mon Jun 6 15:29:25 2011 -0400
>
> security: new security_inode_init_security API adds function callback
>
> I can repost these after this commit hits Linus' kernel if necessary.
I see. OK, please repost when they hit Linus' kernel since I guess it's
not urgent to merge these.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-05 20:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 22:07 [PATCH] ext3/xattr_seciruty.c: local functions should be static H Hartley Sweeten
2011-10-04 23:37 ` Jan Kara
2011-10-05 17:27 ` H Hartley Sweeten
2011-10-05 20:18 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®