From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pelle Windestam <pelle@windestam.se>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings
Date: Mon, 10 Oct 2011 10:52:50 +0300 [thread overview]
Message-ID: <20111010075250.GY18470@longonot.mountain> (raw)
In-Reply-To: <1318225337-25438-1-git-send-email-pelle@windestam.se>
On Mon, Oct 10, 2011 at 07:42:17AM +0200, Pelle Windestam wrote:
> -static struct pci_device_id rtsx_ids[] = {
> - { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> - { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> - { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_OTHERS << 16, 0xFF0000 },
> +static DEFINE_PCI_DEVICE_TABLE(rtsx_ids) = {
> + { 0x10EC, 0x5208, PCI_ANY_ID, PCI_ANY_ID,
> + PCI_CLASS_OTHERS << 16, 0xFF0000 },
> + { 0x10EC, 0x5209, PCI_ANY_ID, PCI_ANY_ID,
> + PCI_CLASS_OTHERS << 16, 0xFF0000 },
> + { 0x10EC, 0x5288, PCI_ANY_ID, PCI_ANY_ID,
> + PCI_CLASS_OTHERS << 16, 0xFF0000 },
> { 0, },
> };
This looked nicer in the original version. I know that checkpatch
complains but in the end, checkpatch is just a perl script. It's
less sentient than a squirrel.
regards,
dan carpenter
next prev parent reply other threads:[~2011-10-10 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 5:42 Pelle Windestam
2011-10-10 7:52 ` Dan Carpenter [this message]
2011-10-10 15:14 ` Pelle Windestam
2011-10-10 16:13 ` Joe Perches
2011-10-10 16:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010075250.GY18470@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pelle@windestam.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®