From: Greg KH <gregkh@suse.de>
To: Pelle Windestam <pelle@windestam.se>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rts_pstor fixed checkpatch warnings
Date: Mon, 10 Oct 2011 09:13:36 -0700 [thread overview]
Message-ID: <20111010161336.GB23072@suse.de> (raw)
In-Reply-To: <CAOdCkm1YNJ2xkVk+p1MTxX_e_5T8UM9Tz7mWE5v5JUhHOuenEg@mail.gmail.com>
On Mon, Oct 10, 2011 at 05:14:27PM +0200, Pelle Windestam wrote:
> On Mon, Oct 10, 2011 at 9:52 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > This looked nicer in the original version. I know that checkpatch
> > complains but in the end, checkpatch is just a perl script. It's
> > less sentient than a squirrel.
> >
> > regards,
> > dan carpenter
> >
>
> I have to agree with you on that, but I wasn't sure how strictly to
> follow the checkpatch warnings. I'll happily resubmit the patch
> without this change if nobody minds.
Please do.
prev parent reply other threads:[~2011-10-10 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 5:42 Pelle Windestam
2011-10-10 7:52 ` Dan Carpenter
2011-10-10 15:14 ` Pelle Windestam
2011-10-10 16:13 ` Joe Perches
2011-10-10 16:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010161336.GB23072@suse.de \
--to=gregkh@suse.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pelle@windestam.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®