From: Grant Likely <grant.likely@secretlab.ca>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi/spi-ep93xx: add module.h include
Date: Sat, 15 Oct 2011 22:23:28 -0600 [thread overview]
Message-ID: <20111016042328.GC4901@ponder.secretlab.ca> (raw)
In-Reply-To: <1318704009-8178-1-git-send-email-mika.westerberg@iki.fi>
On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote:
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
Why? The commit text needs to explain why the patch is required.
g.
> ---
> drivers/spi/spi-ep93xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index 1cf6454..11515c5 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -24,6 +24,7 @@
> #include <linux/dmaengine.h>
> #include <linux/bitops.h>
> #include <linux/interrupt.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/workqueue.h>
> #include <linux/sched.h>
> --
> 1.7.6.3
>
next prev parent reply other threads:[~2011-10-16 4:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 18:40 Mika Westerberg
2011-10-16 4:23 ` Grant Likely [this message]
2011-10-16 7:36 ` Mika Westerberg
2011-10-16 8:04 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111016042328.GC4901@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®