* [PATCH] spi/spi-ep93xx: add module.h include
@ 2011-10-15 18:40 Mika Westerberg
2011-10-16 4:23 ` Grant Likely
0 siblings, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2011-10-15 18:40 UTC (permalink / raw)
To: linux-kernel; +Cc: grant.likely
Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
---
drivers/spi/spi-ep93xx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index 1cf6454..11515c5 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -24,6 +24,7 @@
#include <linux/dmaengine.h>
#include <linux/bitops.h>
#include <linux/interrupt.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/workqueue.h>
#include <linux/sched.h>
--
1.7.6.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/spi-ep93xx: add module.h include
2011-10-15 18:40 [PATCH] spi/spi-ep93xx: add module.h include Mika Westerberg
@ 2011-10-16 4:23 ` Grant Likely
2011-10-16 7:36 ` Mika Westerberg
0 siblings, 1 reply; 4+ messages in thread
From: Grant Likely @ 2011-10-16 4:23 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-kernel
On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote:
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
Why? The commit text needs to explain why the patch is required.
g.
> ---
> drivers/spi/spi-ep93xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index 1cf6454..11515c5 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -24,6 +24,7 @@
> #include <linux/dmaengine.h>
> #include <linux/bitops.h>
> #include <linux/interrupt.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/workqueue.h>
> #include <linux/sched.h>
> --
> 1.7.6.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/spi-ep93xx: add module.h include
2011-10-16 4:23 ` Grant Likely
@ 2011-10-16 7:36 ` Mika Westerberg
2011-10-16 8:04 ` Grant Likely
0 siblings, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2011-10-16 7:36 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel
On Sat, Oct 15, 2011 at 10:23:28PM -0600, Grant Likely wrote:
> On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote:
> > Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
>
> Why? The commit text needs to explain why the patch is required.
How about following then?
From: Mika Westerberg <mika.westerberg@iki.fi>
Subject: [PATCHv2] spi/spi-ep93xx: add module.h include
Due to module.h cleanup it is not anymore included implicitly. Drivers who
want to use it need to include it explicitly.
Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
---
drivers/spi/spi-ep93xx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index 1cf6454..11515c5 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -24,6 +24,7 @@
#include <linux/dmaengine.h>
#include <linux/bitops.h>
#include <linux/interrupt.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/workqueue.h>
#include <linux/sched.h>
--
1.7.6.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] spi/spi-ep93xx: add module.h include
2011-10-16 7:36 ` Mika Westerberg
@ 2011-10-16 8:04 ` Grant Likely
0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2011-10-16 8:04 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-kernel
On Sun, Oct 16, 2011 at 1:36 AM, Mika Westerberg <mika.westerberg@iki.fi> wrote:
> On Sat, Oct 15, 2011 at 10:23:28PM -0600, Grant Likely wrote:
>> On Sat, Oct 15, 2011 at 09:40:09PM +0300, Mika Westerberg wrote:
>> > Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
>>
>> Why? The commit text needs to explain why the patch is required.
>
> How about following then?
>
> From: Mika Westerberg <mika.westerberg@iki.fi>
> Subject: [PATCHv2] spi/spi-ep93xx: add module.h include
>
> Due to module.h cleanup it is not anymore included implicitly. Drivers who
> want to use it need to include it explicitly.
Perfect, thanks. Applied.
g.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
> ---
> drivers/spi/spi-ep93xx.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index 1cf6454..11515c5 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -24,6 +24,7 @@
> #include <linux/dmaengine.h>
> #include <linux/bitops.h>
> #include <linux/interrupt.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/workqueue.h>
> #include <linux/sched.h>
> --
> 1.7.6.3
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-16 8:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-15 18:40 [PATCH] spi/spi-ep93xx: add module.h include Mika Westerberg
2011-10-16 4:23 ` Grant Likely
2011-10-16 7:36 ` Mika Westerberg
2011-10-16 8:04 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®