[PATCH] kernel/power/main.c : Fix indentation and remove extraneous whitespaces

[PATCH] kernel/power/main.c : Fix indentation and remove extraneous whitespaces

[Srivatsa S. Bhat]

Lack of proper indentation of the goto statement decreases the readability
of code significantly. In fact, this made me look twice at the code to check
whether it really does what it should be doing. Fix this.

And in the same file, there are some extra whitespaces. Get rid of them too.

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
---

 kernel/power/main.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/power/main.c b/kernel/power/main.c
index 71f49fe..670fb08 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -3,7 +3,7 @@
  *
  * Copyright (c) 2003 Patrick Mochel
  * Copyright (c) 2003 Open Source Development Lab
- * 
+ *
  * This file is released under the GPLv2
  *
  */
@@ -240,7 +240,7 @@ struct kobject *power_kobj;
  *	'standby' (Power-On Suspend), 'mem' (Suspend-to-RAM), and
  *	'disk' (Suspend-to-Disk).
  *
- *	store() accepts one of those strings, translates it into the 
+ *	store() accepts one of those strings, translates it into the
  *	proper enumerated value, and initiates a suspend transition.
  */
 static ssize_t state_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -282,7 +282,7 @@ static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr,
 	/* First, check if we are requested to hibernate */
 	if (len == 4 && !strncmp(buf, "disk", len)) {
 		error = hibernate();
-  goto Exit;
+		goto Exit;
 	}
 
 #ifdef CONFIG_SUSPEND

Re: [PATCH] kernel/power/main.c : Fix indentation and remove extraneous whitespaces

[Rafael J. Wysocki]

On Saturday, November 19, 2011, Srivatsa S. Bhat wrote:
> Lack of proper indentation of the goto statement decreases the readability
> of code significantly. In fact, this made me look twice at the code to check
> whether it really does what it should be doing. Fix this.
> 
> And in the same file, there are some extra whitespaces. Get rid of them too.
> 
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Applied to linux-pm/linux-next.

Thanks,
Rafael


> ---
> 
>  kernel/power/main.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 71f49fe..670fb08 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -3,7 +3,7 @@
>   *
>   * Copyright (c) 2003 Patrick Mochel
>   * Copyright (c) 2003 Open Source Development Lab
> - * 
> + *
>   * This file is released under the GPLv2
>   *
>   */
> @@ -240,7 +240,7 @@ struct kobject *power_kobj;
>   *	'standby' (Power-On Suspend), 'mem' (Suspend-to-RAM), and
>   *	'disk' (Suspend-to-Disk).
>   *
> - *	store() accepts one of those strings, translates it into the 
> + *	store() accepts one of those strings, translates it into the
>   *	proper enumerated value, and initiates a suspend transition.
>   */
>  static ssize_t state_show(struct kobject *kobj, struct kobj_attribute *attr,
> @@ -282,7 +282,7 @@ static ssize_t state_store(struct kobject *kobj, struct kobj_attribute *attr,
>  	/* First, check if we are requested to hibernate */
>  	if (len == 4 && !strncmp(buf, "disk", len)) {
>  		error = hibernate();
> -  goto Exit;
> +		goto Exit;
>  	}
>  
>  #ifdef CONFIG_SUSPEND
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: [PATCH] kernel/power/main.c : Fix indentation and remove extraneous whitespaces

[Pavel Machek]

On Sat 2011-11-19 14:42:41, Srivatsa S. Bhat wrote:
> Lack of proper indentation of the goto statement decreases the readability
> of code significantly. In fact, this made me look twice at the code to check
> whether it really does what it should be doing. Fix this.
> 
> And in the same file, there are some extra whitespaces. Get rid of them too.
> 
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

ACK.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html