From: Thomas Renninger <trenn@suse.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, kay.sievers@vrf.org,
Andi Kleen <ak@linux.intel.com>,
davej@redhat.com, kay.sievers@vrfy.org
Subject: Re: [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3
Date: Wed, 21 Dec 2011 12:03:25 +0100 [thread overview]
Message-ID: <201112211203.26153.trenn@suse.de> (raw)
In-Reply-To: <1324338394-4670-8-git-send-email-andi@firstfloor.org>
On Tuesday, December 20, 2011 12:46:33 AM Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> This marks all the x86 cpuinfo tables to the CPU specific device drivers,
> to allow auto loading by udev. This should simplify the distribution
> startup scripts for this greatly.
>
> I didn't add MODULE_DEVICE_IDs to the centrino and p4-clockmod drivers,
> because those probably shouldn't be auto loaded and the acpi driver
> be used instead (not fully sure on that, would appreciate feedback)
>
> The old nforce drivers autoload based on the PCI ID.
>
> ACPI cpufreq is autoloaded in another patch.
>
> v3: Autoload gx based on PCI IDs only. Remove cpu check (Dave Jones)
> Cc: davej@redhat.com
> Cc: trenn@suse.de
> Cc: kay.sievers@vrfy.org
> Cc: hpa@zytor.com
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
...
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index bce576d..c87fabb 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -37,6 +37,7 @@
> #include <linux/delay.h>
>
> #include <asm/msr.h>
> +#include <asm/cpu_device_id.h>
>
> #include <linux/acpi.h>
> #include <linux/mutex.h>
> @@ -514,6 +515,18 @@ static int core_voltage_post_transition(struct powernow_k8_data *data,
> return 0;
> }
>
> +static const struct x86_cpu_id powernow_k8_ids[] = {
> + { X86_VENDOR_AMD, 0xf, },
> + { X86_VENDOR_AMD, 0x10, },
> + { X86_VENDOR_AMD, 0x11, },
> + { X86_VENDOR_AMD, 0x12, },
> + { X86_VENDOR_AMD, 0x13, },
> + { X86_VENDOR_AMD, 0x14, },
{ X86_VENDOR_AMD, 0x15, },
Should also have BullDozer family included.
> + /* Add more here? */
> + {}
Thomas
next prev parent reply other threads:[~2011-12-21 11:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 23:46 CPUID based driver autoloading v3 Andi Kleen
2011-12-19 23:46 ` [PATCH 1/8] Add driver auto probing for x86 features v2 Andi Kleen
2011-12-20 1:25 ` [tip:x86/autoprobe] x86: Add driver auto probing for x86 features tip-bot for Andi Kleen
2011-12-23 13:16 ` [PATCH 1/8] Add driver auto probing for x86 features v2 Thomas Renninger
2011-12-19 23:46 ` [PATCH 2/8] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers Andi Kleen
2011-12-20 1:26 ` [tip:x86/autoprobe] x86, " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 3/8] intel-idle: convert to x86_cpu_id auto probing Andi Kleen
2011-12-20 1:27 ` [tip:x86/autoprobe] x86, " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 4/8] ACPI: Load acpi-cpufreq from processor driver automatically Andi Kleen
2011-12-20 1:28 ` [tip:x86/autoprobe] x86, acpi: " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 5/8] HWMON: Convert via-cputemp to x86 cpuid autoprobing Andi Kleen
2011-12-20 1:28 ` [tip:x86/autoprobe] x86, hwmon: " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 6/8] HWMON: Convert coretemp " Andi Kleen
2011-12-20 1:29 ` [tip:x86/autoprobe] x86, hwmon: " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3 Andi Kleen
2011-12-20 1:30 ` [tip:x86/autoprobe] x86, cpufreq: Add support for x86 cpuinfo auto loading tip-bot for Andi Kleen
2011-12-20 10:12 ` Ingo Molnar
2011-12-20 18:18 ` Andi Kleen
2011-12-21 11:03 ` Thomas Renninger [this message]
2011-12-21 20:12 ` [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3 Andi Kleen
2011-12-21 20:14 ` H. Peter Anvin
2011-12-21 21:30 ` Dave Jones
2011-12-22 0:01 ` Andi Kleen
2011-12-22 0:08 ` H. Peter Anvin
2011-12-22 0:14 ` Andi Kleen
2011-12-22 15:29 ` Thomas Renninger
2011-12-22 20:49 ` Andi Kleen
2011-12-22 17:55 ` [PATCH] X86: Introduce HW-Pstate scattered cpuid feature Thomas Renninger
2011-12-19 23:46 ` [PATCH 8/8] x86: autoload microcode driver on Intel and AMD systems Andi Kleen
2011-12-20 1:31 ` [tip:x86/autoprobe] x86: Autoload " tip-bot for Andi Kleen
2011-12-21 15:02 ` [PATCH 9/8] CPU: Introduce ARCH_HAS_CPU_AUTOPROBE and X86 parts Thomas Renninger
2011-12-21 15:32 ` Kay Sievers
2011-12-21 23:29 ` Greg KH
2011-12-21 23:36 ` H. Peter Anvin
2011-12-21 23:46 ` Kay Sievers
2011-12-21 23:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112211203.26153.trenn@suse.de \
--to=trenn@suse.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=hpa@zytor.com \
--cc=kay.sievers@vrf.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome