From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Thomas Renninger <trenn@suse.de>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kay.sievers@vrf.org,
davej@redhat.com, kay.sievers@vrfy.org
Subject: Re: [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3
Date: Wed, 21 Dec 2011 12:14:57 -0800 [thread overview]
Message-ID: <4EF23E41.40608@zytor.com> (raw)
In-Reply-To: <20111221201227.GA9262@alboin.amr.corp.intel.com>
On 12/21/2011 12:12 PM, Andi Kleen wrote:
>>> +static const struct x86_cpu_id powernow_k8_ids[] = {
>>> + { X86_VENDOR_AMD, 0xf, },
>>> + { X86_VENDOR_AMD, 0x10, },
>>> + { X86_VENDOR_AMD, 0x11, },
>>> + { X86_VENDOR_AMD, 0x12, },
>>> + { X86_VENDOR_AMD, 0x13, },
>>> + { X86_VENDOR_AMD, 0x14, },
>> { X86_VENDOR_AMD, 0x15, },
>>
>> Should also have BullDozer family included.
>
> I think it really needs a cpuid feature bit for the hwpstate. This is
> not in one of the normal CPUID leaves, so the amd specific CPU init
> code would need to set it.
>
> I added 0x15 for now, but it would be good if someone with the hardware
> fixed it like this.
>
> Then could just add a match on "AMD-hw pstate" or so.
>
Agreed. This is literally screaming for a synthetic CPUID bit.
-hpa
next prev parent reply other threads:[~2011-12-21 20:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 23:46 CPUID based driver autoloading v3 Andi Kleen
2011-12-19 23:46 ` [PATCH 1/8] Add driver auto probing for x86 features v2 Andi Kleen
2011-12-20 1:25 ` [tip:x86/autoprobe] x86: Add driver auto probing for x86 features tip-bot for Andi Kleen
2011-12-23 13:16 ` [PATCH 1/8] Add driver auto probing for x86 features v2 Thomas Renninger
2011-12-19 23:46 ` [PATCH 2/8] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers Andi Kleen
2011-12-20 1:26 ` [tip:x86/autoprobe] x86, " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 3/8] intel-idle: convert to x86_cpu_id auto probing Andi Kleen
2011-12-20 1:27 ` [tip:x86/autoprobe] x86, " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 4/8] ACPI: Load acpi-cpufreq from processor driver automatically Andi Kleen
2011-12-20 1:28 ` [tip:x86/autoprobe] x86, acpi: " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 5/8] HWMON: Convert via-cputemp to x86 cpuid autoprobing Andi Kleen
2011-12-20 1:28 ` [tip:x86/autoprobe] x86, hwmon: " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 6/8] HWMON: Convert coretemp " Andi Kleen
2011-12-20 1:29 ` [tip:x86/autoprobe] x86, hwmon: " tip-bot for Andi Kleen
2011-12-19 23:46 ` [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3 Andi Kleen
2011-12-20 1:30 ` [tip:x86/autoprobe] x86, cpufreq: Add support for x86 cpuinfo auto loading tip-bot for Andi Kleen
2011-12-20 10:12 ` Ingo Molnar
2011-12-20 18:18 ` Andi Kleen
2011-12-21 11:03 ` [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loading v3 Thomas Renninger
2011-12-21 20:12 ` Andi Kleen
2011-12-21 20:14 ` H. Peter Anvin [this message]
2011-12-21 21:30 ` Dave Jones
2011-12-22 0:01 ` Andi Kleen
2011-12-22 0:08 ` H. Peter Anvin
2011-12-22 0:14 ` Andi Kleen
2011-12-22 15:29 ` Thomas Renninger
2011-12-22 20:49 ` Andi Kleen
2011-12-22 17:55 ` [PATCH] X86: Introduce HW-Pstate scattered cpuid feature Thomas Renninger
2011-12-19 23:46 ` [PATCH 8/8] x86: autoload microcode driver on Intel and AMD systems Andi Kleen
2011-12-20 1:31 ` [tip:x86/autoprobe] x86: Autoload " tip-bot for Andi Kleen
2011-12-21 15:02 ` [PATCH 9/8] CPU: Introduce ARCH_HAS_CPU_AUTOPROBE and X86 parts Thomas Renninger
2011-12-21 15:32 ` Kay Sievers
2011-12-21 23:29 ` Greg KH
2011-12-21 23:36 ` H. Peter Anvin
2011-12-21 23:46 ` Kay Sievers
2011-12-21 23:50 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF23E41.40608@zytor.com \
--to=hpa@zytor.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=kay.sievers@vrf.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome