* [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 @ 2012-01-23 3:54 Kirill A. Shutemov 2012-01-23 21:18 ` Michal Marek 0 siblings, 1 reply; 4+ messages in thread From: Kirill A. Shutemov @ 2012-01-23 3:54 UTC (permalink / raw) To: linux-kbuild, Michal Marek Cc: Artem Bityutskiy, Jacob Pan, linux-kernel, Kirill A. Shutemov -Wmissing-field-initializers is too noisy to be useful on W=1. Let's move it to W=2. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- scripts/Makefile.build | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index d2b366c..1535a2f 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -62,7 +62,7 @@ endif ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS warning- := $(empty) -warning-1 := -Wextra -Wunused -Wno-unused-parameter +warning-1 := -Wextra -Wunused -Wno-unused-parameter -Wno-missing-field-initializers warning-1 += -Wmissing-declarations warning-1 += -Wmissing-format-attribute warning-1 += -Wmissing-prototypes @@ -75,6 +75,7 @@ warning-2 += -Wcast-align warning-2 += -Wdisabled-optimization warning-2 += -Wnested-externs warning-2 += -Wshadow +warning-2 += -Wmissing-field-initializers warning-2 += $(call cc-option, -Wlogical-op) warning-3 := -Wbad-function-cast -- 1.7.8.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 2012-01-23 3:54 [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 Kirill A. Shutemov @ 2012-01-23 21:18 ` Michal Marek 2012-01-24 3:10 ` Kirill A. Shutemov 0 siblings, 1 reply; 4+ messages in thread From: Michal Marek @ 2012-01-23 21:18 UTC (permalink / raw) To: Kirill A. Shutemov Cc: linux-kbuild, Artem Bityutskiy, Jacob Pan, linux-kernel On Mon, Jan 23, 2012 at 05:54:10AM +0200, Kirill A. Shutemov wrote: > -Wmissing-field-initializers is too noisy to be useful on W=1. Let's > move it to W=2. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > --- > scripts/Makefile.build | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > index d2b366c..1535a2f 100644 > --- a/scripts/Makefile.build > +++ b/scripts/Makefile.build > @@ -62,7 +62,7 @@ endif > ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS > warning- := $(empty) > > -warning-1 := -Wextra -Wunused -Wno-unused-parameter > +warning-1 := -Wextra -Wunused -Wno-unused-parameter -Wno-missing-field-initializers I would use $(call cc-disable-warning, missing-field-initializers), so that W=1 has a chance of working with gcc 3.x. Michal ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 2012-01-23 21:18 ` Michal Marek @ 2012-01-24 3:10 ` Kirill A. Shutemov 2012-01-26 10:10 ` Michal Marek 0 siblings, 1 reply; 4+ messages in thread From: Kirill A. Shutemov @ 2012-01-24 3:10 UTC (permalink / raw) To: Michal Marek; +Cc: linux-kbuild, Artem Bityutskiy, Jacob Pan, linux-kernel [-- Attachment #1: Type: text/plain, Size: 2327 bytes --] On Mon, Jan 23, 2012 at 10:18:34PM +0100, Michal Marek wrote: > On Mon, Jan 23, 2012 at 05:54:10AM +0200, Kirill A. Shutemov wrote: > > -Wmissing-field-initializers is too noisy to be useful on W=1. Let's > > move it to W=2. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > --- > > scripts/Makefile.build | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/scripts/Makefile.build b/scripts/Makefile.build > > index d2b366c..1535a2f 100644 > > --- a/scripts/Makefile.build > > +++ b/scripts/Makefile.build > > @@ -62,7 +62,7 @@ endif > > ifdef KBUILD_ENABLE_EXTRA_GCC_CHECKS > > warning- := $(empty) > > > > -warning-1 := -Wextra -Wunused -Wno-unused-parameter > > +warning-1 := -Wextra -Wunused -Wno-unused-parameter -Wno-missing-field-initializers > > I would use $(call cc-disable-warning, missing-field-initializers), so > that W=1 has a chance of working with gcc 3.x. Something like this? --- From 9ee1c7006d14efddcb7cd52053b97aa39edf6ec3 Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Date: Mon, 23 Jan 2012 04:59:28 +0200 Subject: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 -Wmissing-field-initializers is too noisy to be useful on W=1. Let's move it to W=2. Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> --- scripts/Makefile.build | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index d2b366c..ff1720d 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -69,6 +69,7 @@ warning-1 += -Wmissing-prototypes warning-1 += -Wold-style-definition warning-1 += $(call cc-option, -Wmissing-include-dirs) warning-1 += $(call cc-option, -Wunused-but-set-variable) +warning-1 += $(call cc-disable-warning, missing-field-initializers) warning-2 := -Waggregate-return warning-2 += -Wcast-align @@ -76,6 +77,7 @@ warning-2 += -Wdisabled-optimization warning-2 += -Wnested-externs warning-2 += -Wshadow warning-2 += $(call cc-option, -Wlogical-op) +warning-2 += $(call cc-option, -Wmissing-field-initializers) warning-3 := -Wbad-function-cast warning-3 += -Wcast-qual -- 1.7.8.3 -- Kirill A. Shutemov [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 2012-01-24 3:10 ` Kirill A. Shutemov @ 2012-01-26 10:10 ` Michal Marek 0 siblings, 0 replies; 4+ messages in thread From: Michal Marek @ 2012-01-26 10:10 UTC (permalink / raw) To: Kirill A. Shutemov Cc: linux-kbuild, Artem Bityutskiy, Jacob Pan, linux-kernel On Tue, Jan 24, 2012 at 05:10:14AM +0200, Kirill A. Shutemov wrote: > Something like this? > > --- > > From 9ee1c7006d14efddcb7cd52053b97aa39edf6ec3 Mon Sep 17 00:00:00 2001 > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > Date: Mon, 23 Jan 2012 04:59:28 +0200 > Subject: [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 > > -Wmissing-field-initializers is too noisy to be useful on W=1. Let's > move it to W=2. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Thanks, applied to kbuild.git#kbuild. Michal ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-26 10:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-01-23 3:54 [PATCH] kbuild: disable -Wmissing-field-initializers for W=1 Kirill A. Shutemov 2012-01-23 21:18 ` Michal Marek 2012-01-24 3:10 ` Kirill A. Shutemov 2012-01-26 10:10 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®