[PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

[PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

[Jesse Gross]

From: Pravin B Shelar <pshelar@nicira.com>

Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
cleanup path i.e. `ip netns delete `.

This issue exists back to 3.0.

CC: Eric W. Biederman <ebiederm@xmission.com>
Reported-by: Justin Pettit <jpettit@nicira.com>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---
 fs/proc/namespaces.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/proc/namespaces.c b/fs/proc/namespaces.c
index 27da860..3551f1f 100644
--- a/fs/proc/namespaces.c
+++ b/fs/proc/namespaces.c
@@ -53,7 +53,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir,
 	ei->ns_ops    = ns_ops;
 	ei->ns	      = ns;
 
-	dentry->d_op = &pid_dentry_operations;
+	d_set_d_op(dentry, &pid_dentry_operations);
 	d_add(dentry, inode);
 	/* Close the race of the process dying before we return the dentry */
 	if (pid_revalidate(dentry, NULL))
-- 
1.7.5.4

Re: [PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

[Eric W. Biederman]

Jesse Gross <jesse@nicira.com> writes:

> From: Pravin B Shelar <pshelar@nicira.com>
>
> Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
> cleanup path i.e. `ip netns delete `.
>
> This issue exists back to 3.0.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Jesse thanks for picking this up and giving this a push.  This is most
definitely the right fix and it most definitely solves issues.   Somehow
this fix got lost when I sent it to Linus the first time.

> CC: Eric W. Biederman <ebiederm@xmission.com>
> Reported-by: Justin Pettit <jpettit@nicira.com>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
> Signed-off-by: Jesse Gross <jesse@nicira.com>
> ---
>  fs/proc/namespaces.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/proc/namespaces.c b/fs/proc/namespaces.c
> index 27da860..3551f1f 100644
> --- a/fs/proc/namespaces.c
> +++ b/fs/proc/namespaces.c
> @@ -53,7 +53,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir,
>  	ei->ns_ops    = ns_ops;
>  	ei->ns	      = ns;
>  
> -	dentry->d_op = &pid_dentry_operations;
> +	d_set_d_op(dentry, &pid_dentry_operations);
>  	d_add(dentry, inode);
>  	/* Close the race of the process dying before we return the dentry */
>  	if (pid_revalidate(dentry, NULL))

Re: [PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

[Jesse Gross]

On Wed, Mar 14, 2012 at 11:43 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
> Jesse Gross <jesse@nicira.com> writes:
>
>> From: Pravin B Shelar <pshelar@nicira.com>
>>
>> Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
>> cleanup path i.e. `ip netns delete `.
>>
>> This issue exists back to 3.0.
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Jesse thanks for picking this up and giving this a push.  This is most
> definitely the right fix and it most definitely solves issues.   Somehow
> this fix got lost when I sent it to Linus the first time.

Thanks Eric, I didn't realize that you had picked it up the first time
around, which is why I figured that I'd try Andrew.  I haven't heard
anything from him so do you want to take it? (I'm not quite sure who
owns this piece of code, sorry if it's already been handled.)

Re: [PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

[Andrew Morton]

On Tue, 13 Mar 2012 19:08:17 -0700
Jesse Gross <jesse@nicira.com> wrote:

> From: Pravin B Shelar <pshelar@nicira.com>
> 
> Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
> cleanup path i.e. `ip netns delete `.
> 
> This issue exists back to 3.0.

What does "fixes" mean?  Please provide a full description of the
user-visible impact of the bug, so that others can ascertain whether
the patch will fix a problem which they're seeing and so that people
like me can work out which kernel versions we should merge it into.

Thanks.

[PATCH] proc-ns: Use d_set_d_op() API to set dentry ops in proc_ns_instantiate().

[Pravin B Shelar]

Use d_set_d_op() so that DCACHE_OP_* flags are set correctly which fixes ns
cleanup path i.e. `ip netns delete `.

Reported-by: Justin Pettit <jpettit@nicira.com>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>

---
 fs/proc/namespaces.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/proc/namespaces.c b/fs/proc/namespaces.c
index 27da860..3551f1f 100644
--- a/fs/proc/namespaces.c
+++ b/fs/proc/namespaces.c
@@ -53,7 +53,7 @@ static struct dentry *proc_ns_instantiate(struct inode *dir,
 	ei->ns_ops    = ns_ops;
 	ei->ns	      = ns;
 
-	dentry->d_op = &pid_dentry_operations;
+	d_set_d_op(dentry, &pid_dentry_operations);
 	d_add(dentry, inode);
 	/* Close the race of the process dying before we return the dentry */
 	if (pid_revalidate(dentry, NULL))
-- 
1.7.1