From: Kees Cook <keescook@chromium.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
Darren Hart <dvhart@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andrew Morton <akpm@linux-foundation.org>,
Jiri Kosina <jkosina@suse.cz>,
"Eric W. Biederman" <ebiederm@xmission.com>,
David Howells <dhowells@redhat.com>,
"Serge E. Hallyn" <serge.hallyn@canonical.com>,
linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com,
spender@grsecurity.net
Subject: [PATCH v2] futex: mark get_robust_list as deprecated
Date: Fri, 23 Mar 2012 12:08:55 -0700 [thread overview]
Message-ID: <20120323190855.GA27213@www.outflux.net> (raw)
In-Reply-To: <alpine.LFD.2.02.1203231926000.2542@ionos>
Notify get_robust_list users that the syscall is going away.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
v2:
- add note to feature-removal-schedule.txt.
---
Documentation/feature-removal-schedule.txt | 10 ++++++++++
kernel/futex.c | 2 ++
kernel/futex_compat.c | 2 ++
3 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 4bfd982..e3bf119 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -543,3 +543,13 @@ When: 3.5
Why: The old kmap_atomic() with two arguments is deprecated, we only
keep it for backward compatibility for few cycles and then drop it.
Who: Cong Wang <amwang@redhat.com>
+
+----------------------------
+
+What: get_robust_list syscall
+When: 2013
+Why: There appear to be no production users of the get_robust_list syscall,
+ and it runs the risk of leaking address locations, allowing the bypass
+ of ASLR. It was only ever intended for debugging, so it should be
+ removed.
+Who: Kees Cook <keescook@chromium.org>
diff --git a/kernel/futex.c b/kernel/futex.c
index d701be5..e2b0fb9 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2449,6 +2449,8 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
if (!futex_cmpxchg_enabled)
return -ENOSYS;
+ WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
+
rcu_read_lock();
ret = -ESRCH;
diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
index a9642d5..83e368b 100644
--- a/kernel/futex_compat.c
+++ b/kernel/futex_compat.c
@@ -142,6 +142,8 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
if (!futex_cmpxchg_enabled)
return -ENOSYS;
+ WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
+
rcu_read_lock();
ret = -ESRCH;
--
1.7.0.4
next prev parent reply other threads:[~2012-03-23 19:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 23:12 [PATCH] futex: do not leak robust list to unprivileged process Kees Cook
2012-03-20 13:31 ` Serge Hallyn
2012-03-20 17:02 ` Thomas Gleixner
2012-03-20 17:11 ` Kees Cook
2012-03-20 17:23 ` Ingo Molnar
2012-03-22 23:46 ` Thomas Gleixner
2012-03-23 17:58 ` [PATCH] futex: mark get_robust_list as deprecated Kees Cook
2012-03-23 18:27 ` Thomas Gleixner
2012-03-23 19:08 ` Kees Cook
2012-03-23 19:08 ` Kees Cook [this message]
2012-03-23 22:06 ` [PATCH v2] " Eric W. Biederman
2012-03-23 22:10 ` Kees Cook
2012-03-30 5:05 ` Matt Helsley
2012-03-30 6:14 ` Pavel Emelyanov
2012-03-30 22:51 ` Gene Cooperman
2012-03-27 18:05 ` Josh Boyer
2012-03-27 19:13 ` Peter Zijlstra
2012-03-29 9:56 ` [tip:core/locking] futex: Mark " tip-bot for Kees Cook
2012-08-02 10:35 ` [PATCH v2] futex: mark " richard -rw- weinberger
2012-08-02 11:11 ` Eric W. Biederman
2012-08-03 10:17 ` richard -rw- weinberger
2012-08-03 11:02 ` Cyrill Gorcunov
2012-08-03 11:19 ` richard -rw- weinberger
2012-08-03 11:27 ` Cyrill Gorcunov
2012-08-03 11:30 ` richard -rw- weinberger
2012-08-03 11:35 ` Cyrill Gorcunov
2012-08-03 11:38 ` richard -rw- weinberger
2012-08-03 12:38 ` Pavel Emelyanov
2012-08-03 12:58 ` Eric W. Biederman
2012-08-03 13:00 ` richard -rw- weinberger
2012-08-03 17:16 ` Kees Cook
2012-03-28 18:33 ` [PATCH] futex: do not leak robust list to unprivileged process Kees Cook
2012-03-28 21:24 ` Thomas Gleixner
2012-03-29 9:55 ` [tip:core/locking] futex: Do " tip-bot for Kees Cook
2012-06-19 1:41 ` Wanlong Gao
2012-06-19 2:24 ` Serge Hallyn
2012-06-19 2:32 ` Wanlong Gao
2012-06-19 3:13 ` Serge Hallyn
2012-06-19 3:21 ` Wanlong Gao
2012-06-19 12:23 ` Serge Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323190855.GA27213@www.outflux.net \
--to=keescook@chromium.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dvhart@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=jkosina@suse.cz \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=serge.hallyn@canonical.com \
--cc=spender@grsecurity.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®