[PATCH] misc: emif: fix compilation error

[PATCH] misc: emif: fix compilation error

[Felipe Balbi]

commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
Emif driver with initcall) introduced a compile
error by not removing module_init() when adding
postcore_initcall().

This problem would've been caught by just compiling
the driver as module.

Fix the issue by removing module_init() from the
driver.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/misc/emif.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
index 36fda8e..8725ea9 100644
--- a/drivers/misc/emif.c
+++ b/drivers/misc/emif.c
@@ -1663,7 +1663,6 @@ static void __exit emif_unregister(void)
 }
 
 postcore_initcall(emif_register);
-module_init(emif_register);
 module_exit(emif_unregister);
 MODULE_DESCRIPTION("TI EMIF SDRAM Controller Driver");
 MODULE_LICENSE("GPL");
-- 
1.7.10.2

Re: [PATCH] misc: emif: fix compilation error

[Shilimkar, Santosh]

On Fri, May 25, 2012 at 1:41 PM, Felipe Balbi <balbi@ti.com> wrote:
> commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
> Emif driver with initcall) introduced a compile
> error by not removing module_init() when adding
> postcore_initcall().
>
> This problem would've been caught by just compiling
> the driver as module.
>
> Fix the issue by removing module_init() from the
> driver.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/misc/emif.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
> index 36fda8e..8725ea9 100644
> --- a/drivers/misc/emif.c
> +++ b/drivers/misc/emif.c

This driver is in drivers/memory now and this patch is
certainly not applicable. Looks like you might have seen
this issue with the older, internal version of the driver.

Regards
Santosh

Re: [PATCH] misc: emif: fix compilation error

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Fri, May 25, 2012 at 02:40:18PM +0530, Shilimkar, Santosh wrote:
> On Fri, May 25, 2012 at 1:41 PM, Felipe Balbi <balbi@ti.com> wrote:
> > commit 99d3eccf (ARM: OMAP4/5: EMIF: Probe
> > Emif driver with initcall) introduced a compile
> > error by not removing module_init() when adding
> > postcore_initcall().
> >
> > This problem would've been caught by just compiling
> > the driver as module.
> >
> > Fix the issue by removing module_init() from the
> > driver.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >  drivers/misc/emif.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/misc/emif.c b/drivers/misc/emif.c
> > index 36fda8e..8725ea9 100644
> > --- a/drivers/misc/emif.c
> > +++ b/drivers/misc/emif.c
> 
> This driver is in drivers/memory now and this patch is
> certainly not applicable. Looks like you might have seen
> this issue with the older, internal version of the driver.

could be.. I probably merged something I shouldn't on my master branch
;-)

Weird is that my master is built on top of v3.4... anyway.. forget about
this patch, sorry for the noise.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]