* [PATCH] clk: fix return value check in clk_get
@ 2012-07-20 13:36 Peter De Schrijver
2012-07-20 13:43 ` Peter De Schrijver
2012-07-20 13:44 ` Peter De Schrijver
0 siblings, 2 replies; 3+ messages in thread
From: Peter De Schrijver @ 2012-07-20 13:36 UTC (permalink / raw)
To: Peter De Schrijver; +Cc: Russell King, linux-arm-kernel, linux-kernel
of_clk_get_by_name returns an ERR_PTR on failure. Hence we should use IS_ERR()
and not just check for a non NULL value.
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
drivers/clk/clkdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 8f87b0f..d423c9b 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -157,7 +157,7 @@ struct clk *clk_get(struct device *dev, const char *con_id)
if (dev) {
clk = of_clk_get_by_name(dev->of_node, con_id);
- if (clk && __clk_get(clk))
+ if (!IS_ERR(clk) && __clk_get(clk))
return clk;
}
--
1.7.7.rc0.72.g4b5ea.dirty
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: fix return value check in clk_get
2012-07-20 13:36 [PATCH] clk: fix return value check in clk_get Peter De Schrijver
@ 2012-07-20 13:43 ` Peter De Schrijver
2012-07-20 13:44 ` Peter De Schrijver
1 sibling, 0 replies; 3+ messages in thread
From: Peter De Schrijver @ 2012-07-20 13:43 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel
On Fri, Jul 20, 2012 at 03:36:37PM +0200, Peter De Schrijver wrote:
> of_clk_get_by_name returns an ERR_PTR on failure. Hence we should use IS_ERR()
> and not just check for a non NULL value.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
> drivers/clk/clkdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 8f87b0f..d423c9b 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -157,7 +157,7 @@ struct clk *clk_get(struct device *dev, const char *con_id)
>
> if (dev) {
> clk = of_clk_get_by_name(dev->of_node, con_id);
> - if (clk && __clk_get(clk))
> + if (!IS_ERR(clk) && __clk_get(clk))
> return clk;
> }
http://www.spinics.net/lists/arm-kernel/msg184794.html introduces this
behaviour of of_clk_get_by_name()
Cheers,
Peter.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: fix return value check in clk_get
2012-07-20 13:36 [PATCH] clk: fix return value check in clk_get Peter De Schrijver
2012-07-20 13:43 ` Peter De Schrijver
@ 2012-07-20 13:44 ` Peter De Schrijver
1 sibling, 0 replies; 3+ messages in thread
From: Peter De Schrijver @ 2012-07-20 13:44 UTC (permalink / raw)
To: Russell King, linux-arm-kernel, linux-kernel
On Fri, Jul 20, 2012 at 03:36:37PM +0200, Peter De Schrijver wrote:
> of_clk_get_by_name returns an ERR_PTR on failure. Hence we should use IS_ERR()
> and not just check for a non NULL value.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
> drivers/clk/clkdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 8f87b0f..d423c9b 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -157,7 +157,7 @@ struct clk *clk_get(struct device *dev, const char *con_id)
>
> if (dev) {
> clk = of_clk_get_by_name(dev->of_node, con_id);
> - if (clk && __clk_get(clk))
> + if (!IS_ERR(clk) && __clk_get(clk))
> return clk;
> }
http://www.spinics.net/lists/arm-kernel/msg184794.html introduces this
behaviour of of_clk_get_by_name()
Cheers,
Peter.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-20 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-20 13:36 [PATCH] clk: fix return value check in clk_get Peter De Schrijver
2012-07-20 13:43 ` Peter De Schrijver
2012-07-20 13:44 ` Peter De Schrijver
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome