From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] [S390] do not clobber personality flags in sys_32_personality()
Date: Thu, 2 Aug 2012 14:41:57 +0200 [thread overview]
Message-ID: <20120802124157.GA5742@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1208020910260.14910@pobox.suse.cz>
On Thu, Aug 02, 2012 at 09:11:23AM +0200, Jiri Kosina wrote:
> There are multiple errors in how sys_32_personality() handles personality
> flags stored in top three bytes.
>
> - directly comparing current->personality against PER_LINUX32 doesn't work
> in cases when any of the personality flags stored in the top three bytes
> are used.
> - directly forcefully setting personality to PER_LINUX32 or PER_LINUX
> discards any flags stored in the top three bytes
>
> Fix the first one by properly using personality() macro to compare only
> PER_MASK bytes.
> Fix the second one by setting only the bits that should be set, instead of
> overwriting the whole value.
Applied. Thanks!
prev parent reply other threads:[~2012-08-02 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 18:48 [PATCH] " Jiri Kosina
2012-08-02 7:11 ` [PATCH v2] " Jiri Kosina
2012-08-02 12:41 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802124157.GA5742@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®