From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Anton Arapov <anton@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Rabin Vincent <rabin@rab.in>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] uprobes/powerpc: Do not use arch_uprobe_*_step() helpers
Date: Mon, 29 Oct 2012 11:03:40 +0530 [thread overview]
Message-ID: <20121029053340.GB3400@in.ibm.com> (raw)
In-Reply-To: <20121028173928.GA14649@redhat.com>
On Sun, Oct 28, 2012 at 06:39:28PM +0100, Oleg Nesterov wrote:
> No functional changes.
>
> powerpc is the only user of arch_uprobe_enable/disable_step() helpers,
> but they should die. They can not be used correctly, every arch needs
> its own implementation (like x86 does). And they do not really help
> even as initial-and-almost-working code, arch_uprobe_*_xol() hooks can
> easily use user_enable/disable_single_step() directly.
>
> Change arch_uprobe_*_step() to do nothing, and convert powerpc to use
> ptrace helpers. This is equally wrong, powerpc needs the arch-specific
> fixes.
Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
I will send a powerpc patch to directly use the MSR bits for stepping.
Ananth
next prev parent reply other threads:[~2012-10-29 5:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 17:39 [PATCH 0/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Oleg Nesterov
2012-10-28 17:39 ` [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume() Oleg Nesterov
2012-10-29 5:27 ` Ananth N Mavinakayanahalli
2012-10-29 7:02 ` Srikar Dronamraju
2012-10-29 12:43 ` Oleg Nesterov
2012-10-29 13:28 ` Ananth N Mavinakayanahalli
2012-11-02 5:02 ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 2/4] uprobes/powerpc: Do not use arch_uprobe_*_step() helpers Oleg Nesterov
2012-10-29 5:33 ` Ananth N Mavinakayanahalli [this message]
2012-11-02 5:03 ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 3/4] uprobes/x86: Cleanup the single-stepping code Oleg Nesterov
2012-11-02 12:51 ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 4/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Oleg Nesterov
2012-11-02 12:50 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029053340.GB3400@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rabin@rab.in \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome